-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tool for prebuilt binaries #61
Comments
I don't see the reason why, we need only one version of the binaries, that's because we use N-API that has ABI compatibility |
An example: I want to package an app on macOS for all three platforms. For that, electron-builder needs the respective binaries (this is about platform/architecture, not the node version). The requested platform is specified by the env variables in the electron-builder code I referenced (list of options here: https://github.com/mapbox/node-pre-gyp#options) |
But we already have the binaries published for the different OS... they're the ones downloaded to avoid compilation. Does electron-builder needs some different naming scheme for them? |
No, it't just that electron-builder needs to download a binary for Windows if I'm creating a Windows package on my Mac. There is currently no way to do that. |
If it's not a problem about the name of the packages, so what exactly? |
There has to be a way for a packaging tool to tell the libui-napi download tool which version it should download.
No, because electron-builder doesn't download the binaries. libui-napi/tools/libui-download.js and libui-napi/tools/ibui-napi-download.js do. |
Maybe |
No, that is fine as it is. There just has to be a way (by using libui-napi/tools/libui-download.js Line 24 in aa7e275
|
😝😝 I taked my time, but finally I understand what you mean!! It's probably not working becuase noone never used it... |
In this issue kusti8/proton-native#179 (comment) develar mentioned that for "cross-packaging" (for a different platform) we should use https://www.npmjs.com/package/prebuild (so the platform/arch to download binaries for can be set via an environment variable by electron-builder (here).
The text was updated successfully, but these errors were encountered: