Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom log-level breaks the startup process #1117

Closed
pgherveou opened this issue Jun 12, 2023 · 2 comments · Fixed by #1166
Closed

Custom log-level breaks the startup process #1117

pgherveou opened this issue Jun 12, 2023 · 2 comments · Fixed by #1166
Labels
bug Something isn't working good first issue Good for newcomers native-provider

Comments

@pgherveou
Copy link
Contributor

pgherveou commented Jun 12, 2023

Is your feature request related to a problem? Please describe.

I was trying to configure my parachain with the following log level

  env = [{ name = "RUST_LOG", value = "error,runtime::contracts=debug" }]

so that, it's not too verbose and I only get the log events that I need for debugging.
Unfortunately, it looks like no logs is interpreted as a signal that something is not started correctly

Error: Log lines of process: 64378 ( node: collator-1 ) doesn't grow, please check logs at /Users/pg/Documents/zombienet/collator-1.log

Describe the solution you'd like

Ideally setting a custom log level should not impact the "readiness" checks

Describe alternatives you've considered

For now I can just use info as the default log level to workaround this.

Additional context

No response

@pepoviola
Copy link
Collaborator

Hi @pgherveou, thanks for your feedback. Make sense to relax the check in native and just ensure that the process is alive after a couple of secs. We will fix it and ping you to confirm.
Thanks!

cc @wirednkod / @l0r1s, same goes to the sdk.

@pepoviola pepoviola added bug Something isn't working enhancement New feature or request good first issue Good for newcomers native-provider and removed enhancement New feature or request labels Jun 12, 2023
@pepoviola
Copy link
Collaborator

Hi @pgherveou fixed in #1166, will be part of the next release. (I plan to make a new one today).
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers native-provider
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants