Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix codegen validation when Runtime APIs are stripped #976

Closed
jsdw opened this issue May 24, 2023 · 0 comments · Fixed by #1000
Closed

Fix codegen validation when Runtime APIs are stripped #976

jsdw opened this issue May 24, 2023 · 0 comments · Fixed by #1000
Assignees
Labels
bug Something isn't working

Comments

@jsdw
Copy link
Collaborator

jsdw commented May 24, 2023

The CLI tool can now strip out specific runtime APIs as well as specific pallets.

We have a method in the codegen called validate_codegen which compares some node metadata against the generated code. It takes into account only those pallets that we explicitly generated, but does not do the same for Runtime APIs (so when runtime APIs are stripped the metadata will never compare equal to node metadata).

Let's fix that (preferably after #974 merges since it changes things in this area).

@jsdw jsdw changed the title Support validating codegen when Runtime APIs are stripped Fix codegen validation when Runtime APIs are stripped May 24, 2023
@jsdw jsdw added the bug Something isn't working label May 24, 2023
@tadeohepperle tadeohepperle self-assigned this Jun 5, 2023
@jsdw jsdw closed this as completed in #1000 Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants