Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

subscribe_to_updates is a misleading name #788

Closed
kylezs opened this issue Jan 17, 2023 · 2 comments · Fixed by #792
Closed

subscribe_to_updates is a misleading name #788

kylezs opened this issue Jan 17, 2023 · 2 comments · Fixed by #792

Comments

@kylezs
Copy link
Contributor

kylezs commented Jan 17, 2023

There are no subscriptions occurring here, it just creates a new object.
@jsdw
Copy link
Collaborator

jsdw commented Jan 17, 2023 •
edited
Loading

I do sortof agree, and wouldn't be opposed to this being renamed to .updater(); what do you think? I would accept a PR for such a thing!

@kylezs
Copy link
Contributor Author

kylezs commented Jan 17, 2023 •
edited
Loading

updater() sounds fine to me, will try get a PR up tomorrow

@kylezs kylezs mentioned this issue Jan 18, 2023
Merged
@jsdw jsdw closed this as completed in #792 Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

rename subscribe_to_updates() to updater() kylezs/subxt
2 participants
@jsdw @kylezs