Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

CI: trigger simnet master and wait for status #7899

Merged
merged 4 commits into from
Jan 14, 2021
Merged

Conversation

TriplEight
Copy link
Contributor

@TriplEight TriplEight commented Jan 14, 2021

  • trigger SimNet pipeline only when "nightly" variable is passed via schedule against `master branch
  • remove ./maintain/chaosnet as it's in SimNet repo for a while
  • remove flaming-fir deployment as it's no longer used

There's one "but" with this CI triggering: if remote CI is stuck, this pipeline will hang in the running state until manually stopped.

Next stage will be passing the variable to SimNet CI. Variable will bear the container tag name. This will require some changes:
Due to trigger: limitations it's impossible to pass a custom variable.
TLDR;

  1. it's impossible to pass something into variables: in GitLab, and the common workaround is passing it with artifacts
  2. trigger: does not support script: so the workaround with passing via artifacts won't work
  3. I do not want to curl around it

That said, we've agreed with @s3krit that it won't hurt to substitute the current substrate --version ~ 2.0.0-d3b1f2 "pinned" image tag with GitLab built-in CI_COMMIT_SHORT_SHA.

@TriplEight TriplEight added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Jan 14, 2021
@TriplEight TriplEight self-assigned this Jan 14, 2021
Copy link
Contributor

@radupopa2010 radupopa2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TriplEight TriplEight requested a review from bkchr January 14, 2021 18:43
@TriplEight TriplEight merged commit f1c6725 into master Jan 14, 2021
@TriplEight TriplEight deleted the 3x8_trigger_simnet branch January 14, 2021 18:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants