Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Update Pallet placeholder struct as per FRAME v2 #14348

Conversation

abhi3700
Copy link
Contributor

In the entire codebase, this change has been done as per FRAME v3:

- pub struct Pallet<T>(PhantomData<T>);
+ pub struct Pallet<T>(_);

That's it!

@abhi3700 abhi3700 requested review from a team June 12, 2023 12:02
@abhi3700 abhi3700 requested review from athei and acatangiu as code owners June 12, 2023 12:02
@abhi3700 abhi3700 requested a review from a team June 12, 2023 12:02
@paritytech-ci paritytech-ci requested a review from a team June 12, 2023 12:06
@kianenigma
Copy link
Contributor

bot fmt

@command-bot
Copy link

command-bot bot commented Jun 12, 2023

@kianenigma https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2970951 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/substrate/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 4-1ca52756-61e9-4707-b940-2596e8068cf5 to cancel this command or bot cancel to cancel all commands in this pull request.

Copy link
Contributor

@kianenigma kianenigma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once formatting is fixed, thanks!

@kianenigma kianenigma changed the title Update Pallet placeholder struct as per FRAME v3 Update Pallet placeholder struct as per FRAME v2 Jun 12, 2023
@command-bot
Copy link

command-bot bot commented Jun 12, 2023

@kianenigma Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2970951 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2970951/artifacts/download.

@ggwpez ggwpez added A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Jun 12, 2023
Copy link
Member

@ggwpez ggwpez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ggwpez
Copy link
Member

ggwpez commented Jun 12, 2023

bot merge

@paritytech-processbot
Copy link

Waiting for commit status.

@paritytech-processbot
Copy link

Merge cancelled due to error. Error: Statuses failed for 7e66913

@ggwpez
Copy link
Member

ggwpez commented Jun 12, 2023

@abhi3700 please fix the CI errors, eg:

error: unused import: `marker::PhantomData`
    --> frame/contracts/src/lib.rs:132:26
     |
 132 | use sp_std::{fmt::Debug, marker::PhantomData, prelude::*};

@abhi3700
Copy link
Contributor Author

Ok will fix it.

Removed the unused import
@abhi3700
Copy link
Contributor Author

@abhi3700 please fix the CI errors, eg:

error: unused import: `marker::PhantomData`
    --> frame/contracts/src/lib.rs:132:26
     |
 132 | use sp_std::{fmt::Debug, marker::PhantomData, prelude::*};

@ggwpez
fixed now.

@ggwpez
Copy link
Member

ggwpez commented Jun 12, 2023

bot merge

@paritytech-processbot
Copy link

Waiting for commit status.

@paritytech-processbot paritytech-processbot bot merged commit 85415fb into paritytech:master Jun 12, 2023
nathanwhit pushed a commit to nathanwhit/substrate that referenced this pull request Jul 19, 2023
* Update Pallet placeholder struct as per FRAME v3

* ".git/.scripts/commands/fmt/fmt.sh"

* Update lib.rs

Removed the unused import

---------

Co-authored-by: command-bot <>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants