Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Democracy: Is LowestUnbaked<T> ever updated? #9739

Closed
JoshOrndorff opened this issue Sep 9, 2021 · 3 comments · Fixed by #9750
Closed

Democracy: Is LowestUnbaked<T> ever updated? #9739

JoshOrndorff opened this issue Sep 9, 2021 · 3 comments · Fixed by #9750
Labels
I3-bug The node fails to follow expected behavior.

Comments

@JoshOrndorff
Copy link
Contributor

JoshOrndorff commented Sep 9, 2021 •
edited
Loading

Looking through the code in pallet democracy, I see that the storage LowestUnbaked<T> is initialized to zero in the genesis build, and it is read in a few places, but I don't see it ever being changed from zero. @thiolliere
@gui1117
Copy link
Contributor

gui1117 commented Sep 9, 2021 •
edited
Loading

Indeed it is suspicious considering it is used, and its doc tends to indicate that it should be updated.

It is the case since #5294 AFAICT

@gui1117 gui1117 mentioned this issue Sep 10, 2021
Merged
@kianenigma kianenigma added the I3-bug The node fails to follow expected behavior. label Sep 17, 2021
@JoshOrndorff
Copy link
Contributor Author

Should this really be closed? This is likely a bug in the code.

@gui1117
Copy link
Contributor

gui1117 commented Oct 18, 2021

the process bot wrote it closed this in #9750 but I agree it is easy to miss

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
I3-bug The node fails to follow expected behavior.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update lowest unbaked storage. paritytech/substrate
3 participants
@JoshOrndorff @kianenigma @gui1117