Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

try-runtime: don't require --block-at in snapshot #9570

Closed
kianenigma opened this issue Aug 16, 2021 · 0 comments · Fixed by #9788
Closed

try-runtime: don't require --block-at in snapshot #9570

kianenigma opened this issue Aug 16, 2021 · 0 comments · Fixed by #9788
Assignees
Labels
I4-annoyance The client behaves within expectations, however this “expected behaviour” itself is at issue.

Comments

@kianenigma
Copy link
Contributor

kianenigma commented Aug 16, 2021

in essence,

/// The block hash at which to read state. This is required for execute-block, offchain-worker,
/// or any command that used the live subcommand.
#[structopt(
	short,
	long,
	multiple = false,
	parse(try_from_str = parse::hash),
	required_ifs(
		&[("command", "offchain-worker"), ("command", "execute-block"), ("subcommand", "live")]
	)
)]
block_at: String,

the required_ifs is not really doing what it is supposed to do. I still can't run on-runtime-upgrade <...> snap <...> without giving a (seemingly unused block-at).

cc @emostov

@kianenigma kianenigma added the I4-annoyance The client behaves within expectations, however this “expected behaviour” itself is at issue. label Aug 16, 2021
@emostov emostov self-assigned this Aug 19, 2021
@ghost ghost closed this as completed in #9788 Sep 21, 2021
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
I4-annoyance The client behaves within expectations, however this “expected behaviour” itself is at issue.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants