Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Remove Offence delay API #8343

Closed
kianenigma opened this issue Mar 12, 2021 · 4 comments · Fixed by #8414
Closed

Remove Offence delay API #8343

kianenigma opened this issue Mar 12, 2021 · 4 comments · Fixed by #8414
Labels
I8-footprint An enhancement to provide a smaller (system load, memory, network or disk) footprint. Z1-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder Z6-mentor An easy task where a mentor is available. Please indicate in the issue who the mentor could be.

Comments

@kianenigma
Copy link
Contributor

With #8113 being merged, we won't need to delay offences anymore. We can remove the can_report api from OnOffenceHandler, and there's a small queue in the pallet-offence that keeps queued Offences, and that needs to also get removed.
@kianenigma kianenigma added I8-footprint An enhancement to provide a smaller (system load, memory, network or disk) footprint. Z6-mentor An easy task where a mentor is available. Please indicate in the issue who the mentor could be. Z1-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder labels Mar 12, 2021
@kianenigma kianenigma mentioned this issue Mar 12, 2021
Merged
@hirschenberger
Copy link
Contributor

hirschenberger commented Mar 20, 2021 •
edited
Loading

I'd like to do it.
The Offences queue to remove is this?

@kianenigma
Copy link
Contributor Author

We're planning to use this task for an internal interview process, could you wait until next week please? I'll keep you posted.

@hirschenberger
Copy link
Contributor

Oh, I'm nearly finished. May I get the job? ;-)

@shawntabrizi
Copy link
Member

@hirschenberger if you are serious about trying to get a job at Parity, please apply online here: https://www.parity.io/jobs/

We are actively hiring in a number of areas :)

@Lohann Lohann mentioned this issue Mar 22, 2021
Merged
6 tasks
@ghost ghost closed this as completed in #8414 May 3, 2021
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
I8-footprint An enhancement to provide a smaller (system load, memory, network or disk) footprint. Z1-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder Z6-mentor An easy task where a mentor is available. Please indicate in the issue who the mentor could be.
Projects
(Nominated) Proof of Stake
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove Offence delay Lohann/substrate
3 participants
@hirschenberger @shawntabrizi @kianenigma