Addresses passed with --public-addr get purged after a while

[tomaka]

The --public-addr CLI option gives the possibility for the user to pass to the node its external IP addresses.

The way it's implemented is that at startup we call libp2p::Swarm::add_external_address:

substrate/client/network/src/service.rs

Lines 381 to 383 in 3654d1a

	for addr in &params.network_config.public_addresses {
	Swarm::<B, H>::add_external_address(&mut swarm, addr.clone());
	}

This, in turn, adds the address to the registry.

However, nodes continue to discover their (probably invalid) external IP address from other nodes.
Because of the way libp2p's Registry is implemented, the addresses passed with --public-addr will eventually get purged. This is obviously not supposed to happen.

The detection is automatically done in libp2p-identify, so Substrate can't disable it.

There seems to be lacking a way in libp2p to implement something like --public-addr.

cc @mxinden @romanb

[tomaka]

For some history: --public-addr was implemented a long time ago when addresses stayed in the libp2p Registry forever.
But we then changed its behaviour to purge old addresses, and didn't think of --public-addr.

[romanb]

I can look into this on the libp2p side.

[tomaka]

@ddorgan The problem with nodes behind nginx not receiving incoming connections should now be fixed.

[ddorgan]

Good news, thanks @tomaka