Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Refactor sc_network::NetworkService::poll to use async/await #6919

Closed
tomaka opened this issue Aug 19, 2020 · 3 comments · Fixed by #13219
Closed

Refactor sc_network::NetworkService::poll to use async/await #6919

tomaka opened this issue Aug 19, 2020 · 3 comments · Fixed by #13219
Assignees
@dmitry-markin
Labels
I7-refactor Code needs refactoring. U2-some_time_soon Issue is worth doing soon. Z2-medium Can be fixed by a coder with good Rust knowledge but little knowledge of the codebase.

Comments

@tomaka
Copy link
Contributor

tomaka commented Aug 19, 2020

Continuation of the discussion in #6903

We should basically re-do https://github.com/paritytech/substrate/pull/5704/files.
@tomaka tomaka added the I7-refactor Code needs refactoring. label Aug 19, 2020
@tomaka tomaka added C3-medium PR touches the given topic and has a medium impact on builders. Z2-medium Can be fixed by a coder with good Rust knowledge but little knowledge of the codebase. and removed C3-medium PR touches the given topic and has a medium impact on builders. labels May 3, 2021
@tomaka
Copy link
Contributor Author

tomaka commented May 3, 2021

Not difficult per se, but marked as "medium" because it's error-prone.

@stale
Copy link

stale bot commented Jul 7, 2021

Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the A5-stale Pull request did not receive any updates in a long time. No review needed at this stage. Close it. label Jul 7, 2021
@tomaka
Copy link
Contributor Author

tomaka commented Jul 8, 2021

Issue still relevant and important.

@stale stale bot removed the A5-stale Pull request did not receive any updates in a long time. No review needed at this stage. Close it. label Jul 8, 2021
@the-right-joyce the-right-joyce moved this to Backlog 🗒 in Networking Aug 25, 2022
@altonen altonen added the U2-some_time_soon Issue is worth doing soon. label Dec 14, 2022
@dmitry-markin dmitry-markin self-assigned this Jan 3, 2023
@dmitry-markin dmitry-markin mentioned this issue Jan 23, 2023
Merged
@altonen altonen moved this from Backlog 🗒 to In Progress 🛠 in Networking Feb 6, 2023
@dmitry-markin dmitry-markin moved this from In Progress 🛠 to Code in review 🧐 in Networking Feb 15, 2023
@github-project-automation github-project-automation bot moved this from Code in review 🧐 to Blocked ⛔️ in Networking Feb 20, 2023
@altonen altonen moved this from Blocked ⛔️ to Done ✅ in Networking Mar 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@dmitry-markin dmitry-markin

Labels
I7-refactor Code needs refactoring. U2-some_time_soon Issue is worth doing soon. Z2-medium Can be fixed by a coder with good Rust knowledge but little knowledge of the codebase.
Projects
Networking
Status: Done ✅
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use async/await instead of manual polling of NetworkWorker paritytech/substrate
3 participants
@tomaka @dmitry-markin @altonen