Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Replace sysinfo crate #6806

Closed
andresilva opened this issue Aug 3, 2020 · 1 comment · Fixed by #6822
Closed

Replace sysinfo crate #6806

andresilva opened this issue Aug 3, 2020 · 1 comment · Fixed by #6822
Labels
U2-some_time_soon Issue is worth doing soon. Z1-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder

Comments

@andresilva
Copy link
Contributor

andresilva commented Aug 3, 2020 •
edited
Loading

The sysinfo crate has caused us some trouble due to the amount of file descriptors it keeps open (#6805). We should look into replacing this crate with something simpler. We seem to only be using it for fetching the average cpu usage and memory (currently working on multiple OS's). All of the process specific info (e.g. number of threads, number of file handles) we are getting directly from procfs and as such we only have Linux support currently.
@andresilva andresilva added U2-some_time_soon Issue is worth doing soon. Z1-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder labels Aug 3, 2020
@andresilva
Copy link
Contributor Author

#6805 removed sysinfo on Linux (data is fetched through procfs), it is still used on macos and windows.

@andresilva andresilva mentioned this issue Aug 5, 2020
Merged
@ghost ghost closed this as completed in #6822 Aug 5, 2020
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
U2-some_time_soon Issue is worth doing soon. Z1-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

service: remove collection of system/process metrics paritytech/substrate
1 participant
@andresilva