Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Operational Transactions #3092

Closed
kianenigma opened this issue Jul 10, 2019 · 5 comments
Closed

Operational Transactions #3092

kianenigma opened this issue Jul 10, 2019 · 5 comments
Assignees
Labels
J0-enhancement An additional feature request.
Milestone

Comments

@kianenigma
Copy link
Contributor

kianenigma commented Jul 10, 2019

These transactions will be

  • Signed.
  • Must be charged fees as a normal tx.
  • Must make sure that they have precedence in inclusion
  • Must make sure that the block weight limit NOT will cause them to be rejected.

Needs:

  • Weighable trait to return the priority. fn priority<B>(&self, encodec_len: usize, tip: B)
  • Weighable to define a function which indicates block fullness. Then we simply return false if we observe an operational tx.

Not much work. Best to do it after #2930 and #2854 are merged.

@kianenigma kianenigma added the J0-enhancement An additional feature request. label Jul 10, 2019
@kianenigma kianenigma added this to the 2.0-alpha milestone Jul 10, 2019
@kianenigma kianenigma self-assigned this Jul 10, 2019
@kianenigma
Copy link
Contributor Author

@rphmeier can you double check that problem definition is correct and will fit what you need? (trying to recall everything we discussed in group)

@gavofyork
Copy link
Member

Must make sure that the block weight limit will cause them to be rejected

is this not missing a negative?

@kianenigma
Copy link
Contributor Author

kianenigma commented Jul 10, 2019

Must make sure that the block weight limit will cause them to be rejected

is this not missing a negative?

yes. (This is a clear sign that I should stop doing stuff for tonight)

@rphmeier
Copy link
Contributor

Why can't we just use regular transactions for this and change the queue-weighting mechanism a little?

Also it would be good to familiarise yourself with #3063 -- this is the runtime API to be used by the node in constructing those calls.

Weighable

nit: naming in Rust would just call the trait Weight or even better Priority, since it has one fn priority.

All traits indicate foo is bar-able...it's completely redundant.

@kianenigma
Copy link
Contributor Author

Closed via #3102 and a bunch of others.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
J0-enhancement An additional feature request.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants