Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Benchmark pallet sudo #13812

Closed
ggwpez opened this issue Apr 3, 2023 · 1 comment · Fixed by #13880
Closed

Benchmark pallet sudo #13812

ggwpez opened this issue Apr 3, 2023 · 1 comment · Fixed by #13880
Labels
Z1-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder Z6-mentor An easy task where a mentor is available. Please indicate in the issue who the mentor could be.

Comments

@ggwpez
Copy link
Member

ggwpez commented Apr 3, 2023 •
edited
Loading

The sudo pallet does not use correct weight annotations in set_key (and probaly other calls as well):

substrate/frame/sudo/src/lib.rs

Lines 198 to 199 in 1bbde5d

#[pallet::weight(0)]
pub fn set_key(

Considering that people use Substrate as reference on how to write good pallets, we should probably do a minimal bench to fix it.
@ggwpez ggwpez added Z6-mentor An easy task where a mentor is available. Please indicate in the issue who the mentor could be. Z1-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder labels Apr 3, 2023
@ggwpez ggwpez changed the title Benchmark pallet Benchmark pallet sudo Apr 3, 2023
@ggwpez ggwpez mentioned this issue Apr 3, 2023
Open
@Doordashcon Doordashcon mentioned this issue Apr 11, 2023
Merged
@Doordashcon
Copy link
Contributor

don't think we need it in sudo extrinsic, sudo_as could be improved on

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Z1-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder Z6-mentor An easy task where a mentor is available. Please indicate in the issue who the mentor could be.
Projects
Benchmarking and Weights
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Benchmark pallet sudo Doordashcon/substrate
2 participants
@ggwpez @Doordashcon