Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Scheduler cleanup #12851

Closed
gavofyork opened this issue Dec 6, 2022 · 3 comments
Closed

Scheduler cleanup #12851

gavofyork opened this issue Dec 6, 2022 · 3 comments

Comments

@gavofyork
Copy link
Member

Scheduler should remove any trailing None items in agendas as items get removed.

A migration should do this for preexisting items.
@dharjeezy
Copy link
Contributor

dharjeezy commented Dec 7, 2022 •
edited
Loading

@gavofyork i will like to pick this up.

So, are you saying the Agenda storage map should not store this

BoundedVec<Option<ScheduledOf<T>>, T::MaxScheduledPerBlock> anymore

but store this instead

BoundedVec<ScheduledOf<T>, T::MaxScheduledPerBlock>?

@muharem muharem mentioned this issue Dec 21, 2022
Merged
@ggwpez
Copy link
Member

ggwpez commented Dec 21, 2022

Done in #12989

@ggwpez ggwpez closed this as completed Dec 21, 2022
@Polkadot-Forum
Copy link

This issue has been mentioned on Polkadot Forum. There might be relevant details there:

https://forum.polkadot.network/t/polkadot-release-analysis-v0-9-37/1736/1

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
Runtime / FRAME
Status: Done
Milestone
No milestone
Development

No branches or pull requests
4 participants
@gavofyork @ggwpez @dharjeezy @Polkadot-Forum