PR feedback

- Spaces -> tabs
- renamed two helper functions

Author: trevor-crypto

primitives/core/src/ecdsa.rs

@@ -382,7 +382,7 @@ impl From<(libsecp256k1::Signature, libsecp256k1::RecoveryId)> for Signature {
 impl<'a> TryFrom<&'a Signature> for (libsecp256k1::Signature, libsecp256k1::RecoveryId) {
 	type Error = ();
 	fn try_from(x: &'a Signature) -> Result<(libsecp256k1::Signature, libsecp256k1::RecoveryId), Self::Error> {
-		parse_signature(&x.0).map_err(|_| ())
+		parse_signature_standard(&x.0).map_err(|_| ())
 	}
 }
 
@@ -508,7 +508,7 @@ impl TraitPair for Pair {
 	fn verify_weak<P: AsRef<[u8]>, M: AsRef<[u8]>>(sig: &[u8], message: M, pubkey: P) -> bool {
 		let message = libsecp256k1::Message::parse(&blake2_256(message.as_ref()));
 		if sig.len() != 65 { return false }
-		let (sig, ri) = match parse_signature(&sig) {
+		let (sig, ri) = match parse_signature_standard(&sig) {
 			Ok(sigri) => sigri,
 			_ => return false,
 		};
@@ -569,7 +569,7 @@ impl Pair {
 	/// Parses Signature using parse_overflowing_slice
 	pub fn verify_deprecated<M: AsRef<[u8]>>(sig: &Signature, message: M, pubkey: &Public) -> bool {
 		let message = libsecp256k1::Message::parse(&blake2_256(message.as_ref()));
-		let (sig, ri) = match parse_signature_deprecated(&sig.0) {
+		let (sig, ri) = match parse_signature_overflowing(&sig.0) {
 			Ok(sigri) => sigri,
 			_ => return false
 		};
@@ -581,21 +581,21 @@ impl Pair {
 }
 
 #[cfg(feature = "full_crypto")]
-fn parse_signature(
-    x: &[u8],
+fn parse_signature_standard(
+	x: &[u8],
 ) -> Result<(libsecp256k1::Signature, libsecp256k1::RecoveryId), libsecp256k1::Error> {
-    let sig = libsecp256k1::Signature::parse_standard_slice(&x[0..64])?;
-    let ri = libsecp256k1::RecoveryId::parse(x[64])?;
-    Ok((sig, ri))
+	let sig = libsecp256k1::Signature::parse_standard_slice(&x[0..64])?;
+	let ri = libsecp256k1::RecoveryId::parse(x[64])?;
+	Ok((sig, ri))
 }
 
 #[cfg(feature = "full_crypto")]
-fn parse_signature_deprecated(
-    x: &[u8],
+fn parse_signature_overflowing(
+	x: &[u8],
 ) -> Result<(libsecp256k1::Signature, libsecp256k1::RecoveryId), libsecp256k1::Error> {
-    let sig = libsecp256k1::Signature::parse_overflowing_slice(&x[0..64])?;
-    let ri = libsecp256k1::RecoveryId::parse(x[64])?;
-    Ok((sig, ri))
+	let sig = libsecp256k1::Signature::parse_overflowing_slice(&x[0..64])?;
+	let ri = libsecp256k1::RecoveryId::parse(x[64])?;
+	Ok((sig, ri))
 }
 
 impl CryptoType for Public {