Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

smoldot can't parse some valid RPC messages #2074

Closed
josepot opened this issue Feb 20, 2022 · 1 comment · Fixed by #2075
Closed

smoldot can't parse some valid RPC messages #2074

josepot opened this issue Feb 20, 2022 · 1 comment · Fixed by #2075
Assignees

Comments

@josepot
Copy link
Contributor

josepot commented Feb 20, 2022

I've created this POC to showcase the issue (run node index.js from the terminal that's at the bottom).

Basically, what happens is that the smoldot chains can't process RPC messages like this one:

'{"jsonrpc":"2.0","id":"extern:\\"health-checker:0\\"","method":"system_health","params":[]}'

Despite the fact that chain.sendJsonRpc doesn't throw, a message gets logged in the console that reads:

Refused malformed JSON-RPC request: data did not match any variant of untagged enum SerdeId
@tomaka
Copy link
Contributor

tomaka commented Feb 20, 2022

Caused by serde-rs/json#742

I wasn't aware of this. It's really bad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants