Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Async Backing: Update Seconded message and dispute statements in vstaging primitives #4960

Closed
rphmeier opened this issue Feb 21, 2022 · 2 comments
Labels
I8-refactor Code needs refactoring.

Comments

@rphmeier
Copy link
Contributor

Seconded should become Seconded(RelayParent, CandidateHash, Depth, ParentCandidateHash) and the dispute statement kinds need to be updated accordingly. Note that the runtime can't reasonably check Depth and ParentCandidateHash so these serve mostly off-chain purposes.

@rphmeier rphmeier added the I8-refactor Code needs refactoring. label Feb 21, 2022
@rphmeier
Copy link
Contributor Author

rphmeier commented Mar 7, 2022

This might not be necessary, if we can come up with a way to redesign statement-distribution to be resistant to spam without considering depth. For the moment, I'm assuming we can do that because it is probably easier (and more elegant) than updating the Seconded message. Adding depth to the Seconded message is a very crude mechanism for spam removal because it still allows for an unnecessarily high degree of forking.

@rphmeier
Copy link
Contributor Author

not necessary in the new pull-based mechanism and statement-distribution redesign (#5055 )

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
I8-refactor Code needs refactoring.
Projects
None yet
Development

No branches or pull requests

1 participant