Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

availability-distribution: fix active leaf processing at session boundaries #4792

Closed
slumber opened this issue Jan 27, 2022 · 1 comment · Fixed by #4850
Closed

availability-distribution: fix active leaf processing at session boundaries #4792

slumber opened this issue Jan 27, 2022 · 1 comment · Fixed by #4850
Assignees
Labels
I3-bug Fails to follow expected behavior. T5-parachains_protocol This PR/Issue is related to Parachains features and protocol changes.

Comments

@slumber
Copy link
Contributor

slumber commented Jan 27, 2022

As noticed by @eskimor

Here we are not actually using the SessionInfo for the leaf, but the SessionInfo for the leaf's child. Therefore, at session boundaries we will look up the backing group in the wrong session. grimacing

(link to the comment)

This is not crucial since such candidates are unlikely to be included anyway, but it's best to keep the behavior consistent.
The actual session index for the activated leaf is obtained here, so it's sufficient to extract it and refactor requester methods to have it as a parameter.

@slumber slumber added the I3-bug Fails to follow expected behavior. label Jan 27, 2022
@eskimor
Copy link
Member

eskimor commented Jan 27, 2022

Thanks @slumber !

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
I3-bug Fails to follow expected behavior. T5-parachains_protocol This PR/Issue is related to Parachains features and protocol changes.
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants