From 13f1ed94852ba504b3c1b766b95559ccd3c08783 Mon Sep 17 00:00:00 2001 From: Sebastian Kunert Date: Tue, 28 Jan 2025 12:55:31 +0100 Subject: [PATCH 1/3] Clarify missing inherent error message. --- cumulus/pallets/parachain-system/src/lib.rs | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/cumulus/pallets/parachain-system/src/lib.rs b/cumulus/pallets/parachain-system/src/lib.rs index fa754ea29ccf5..624f91e7fdfb3 100644 --- a/cumulus/pallets/parachain-system/src/lib.rs +++ b/cumulus/pallets/parachain-system/src/lib.rs @@ -309,8 +309,12 @@ pub mod pallet { >::kill(); let relay_upgrade_go_ahead = >::take(); - let vfp = >::get() - .expect("set_validation_data inherent needs to be present in every block!"); + let vfp = >::get().expect( + r"Missing required set_validation_data inherent. This inherent must be + present in every block. This error typically occurs when the set_validation_data + execution failed and was rejected by the block builder. Check earlier log entries + for the specific cause of the failure.", + ); LastRelayChainBlockNumber::::put(vfp.relay_parent_number); From a7994c537db0e293c969c76ac57362cb9d86ebf0 Mon Sep 17 00:00:00 2001 From: "cmd[bot]" <41898282+github-actions[bot]@users.noreply.github.com> Date: Tue, 28 Jan 2025 12:03:15 +0000 Subject: [PATCH 2/3] Update from skunert running command 'prdoc --bump patch --audience runtime_dev' --- prdoc/pr_7359.prdoc | 8 ++++++++ 1 file changed, 8 insertions(+) create mode 100644 prdoc/pr_7359.prdoc diff --git a/prdoc/pr_7359.prdoc b/prdoc/pr_7359.prdoc new file mode 100644 index 0000000000000..8e0ad7f314c06 --- /dev/null +++ b/prdoc/pr_7359.prdoc @@ -0,0 +1,8 @@ +title: Improve `set_validation_data` error message. +doc: +- audience: Runtime Dev + description: The old error message was often confusing, because the real reason + for the error will be printed during inherent execution. +crates: +- name: cumulus-pallet-parachain-system + bump: patch From 4869dd9fb86c38644eb97001654f6a9123484164 Mon Sep 17 00:00:00 2001 From: Sebastian Kunert Date: Tue, 28 Jan 2025 14:26:00 +0100 Subject: [PATCH 3/3] Update pr_7359.prdoc --- prdoc/pr_7359.prdoc | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/prdoc/pr_7359.prdoc b/prdoc/pr_7359.prdoc index 8e0ad7f314c06..e54fcb877d1de 100644 --- a/prdoc/pr_7359.prdoc +++ b/prdoc/pr_7359.prdoc @@ -1,8 +1,7 @@ title: Improve `set_validation_data` error message. doc: - audience: Runtime Dev - description: The old error message was often confusing, because the real reason - for the error will be printed during inherent execution. + description: Adds a more elaborate error message to the error that appears when `set_validation_data` is missing in a parachain block. crates: - name: cumulus-pallet-parachain-system bump: patch