From f40e1eeac2b09d54d55968e66fbbc58141673c2e Mon Sep 17 00:00:00 2001 From: Alexandru Vasile Date: Tue, 3 Dec 2024 16:24:39 +0000 Subject: [PATCH 1/4] chore: Update litep2p to v0.8.3 Signed-off-by: Alexandru Vasile --- Cargo.toml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Cargo.toml b/Cargo.toml index ecc385504181..49fdc198fe33 100644 --- a/Cargo.toml +++ b/Cargo.toml @@ -848,7 +848,7 @@ linked-hash-map = { version = "0.5.4" } linked_hash_set = { version = "0.1.4" } linregress = { version = "0.5.1" } lite-json = { version = "0.2.0", default-features = false } -litep2p = { version = "0.8.2", features = ["websocket"] } +litep2p = { version = "0.8.3", features = ["websocket"] } log = { version = "0.4.22", default-features = false } macro_magic = { version = "0.5.1" } maplit = { version = "1.0.2" } From 595f5a8d697958917cbdc14acfa07fa764fa8bf2 Mon Sep 17 00:00:00 2001 From: Alexandru Vasile Date: Tue, 3 Dec 2024 16:26:21 +0000 Subject: [PATCH 2/4] cargo: Update cargo lock Signed-off-by: Alexandru Vasile --- Cargo.lock | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Cargo.lock b/Cargo.lock index bc2ebb2a057d..c794ca609d70 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -10225,9 +10225,9 @@ dependencies = [ [[package]] name = "litep2p" -version = "0.8.2" +version = "0.8.3" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "569e7dbec8a0d4b08d30f4942cd579cfe8db5d3f83f8604abe61697c38d17e73" +checksum = "14e490b5a6d486711fd0284bd30e607a287343f2935a59a9192bd7109e85f443" dependencies = [ "async-trait", "bs58", From 181a38770b7d3badb2a2cb34cfaaf5780cdda47b Mon Sep 17 00:00:00 2001 From: Alexandru Vasile Date: Tue, 3 Dec 2024 16:32:30 +0000 Subject: [PATCH 3/4] pr: Add prdoc Signed-off-by: Alexandru Vasile --- prdoc/pr_6742.prdoc | 11 +++++++++++ 1 file changed, 11 insertions(+) create mode 100644 prdoc/pr_6742.prdoc diff --git a/prdoc/pr_6742.prdoc b/prdoc/pr_6742.prdoc new file mode 100644 index 000000000000..92c3755a3c28 --- /dev/null +++ b/prdoc/pr_6742.prdoc @@ -0,0 +1,11 @@ +title: Update litep2p backend to v0.8.3 +doc: +- audience: Node Dev + description: |- + This release includes two fixes for small memory leaks on edge-cases in the notification and request-response protocols. + While at it, have downgraded a log message from litep2p. + +crates: +- name: sc-network + bump: patch + From f3474ea30b661dd6b47ec38f7882d9f0ccd8812b Mon Sep 17 00:00:00 2001 From: Alexandru Vasile Date: Tue, 3 Dec 2024 16:34:41 +0000 Subject: [PATCH 4/4] litep2p: Downgrade log to debug Signed-off-by: Alexandru Vasile --- substrate/client/network/src/litep2p/mod.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/substrate/client/network/src/litep2p/mod.rs b/substrate/client/network/src/litep2p/mod.rs index 6d3575fc2b6b..b6d64b34d64a 100644 --- a/substrate/client/network/src/litep2p/mod.rs +++ b/substrate/client/network/src/litep2p/mod.rs @@ -753,7 +753,7 @@ impl NetworkBackend for Litep2pNetworkBac } if self.litep2p.add_known_address(peer.into(), iter::once(address.clone())) == 0usize { - log::warn!( + log::debug!( target: LOG_TARGET, "couldn't add known address ({address}) for {peer:?}, unsupported transport" );