From ee71f1778b5f6ff53783b7302d173dada8b98c59 Mon Sep 17 00:00:00 2001 From: alvicsam Date: Mon, 18 Dec 2023 10:48:39 +0100 Subject: [PATCH 1/4] [DNM][ci] Debug node-regresion-gueard job --- .gitlab/pipeline/test.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.gitlab/pipeline/test.yml b/.gitlab/pipeline/test.yml index 0e7d96f3dbab..848424b372a4 100644 --- a/.gitlab/pipeline/test.yml +++ b/.gitlab/pipeline/test.yml @@ -305,6 +305,7 @@ node-bench-regression-guard: CI_IMAGE: "paritytech/node-bench-regression-guard:latest" before_script: [""] script: + - ls -la artifacts/benches/ - echo "------- IMPORTANT -------" - echo "node-bench-regression-guard depends on the results of a cargo-check-benches job" - echo "In case of this job failure, check your pipeline's cargo-check-benches" @@ -520,6 +521,6 @@ test-syscalls: - ./list-syscalls.rb ../../../target/x86_64-unknown-linux-musl/production/polkadot-prepare-worker --only-used-syscalls | diff -u prepare-worker-syscalls - after_script: - if [[ "$CI_JOB_STATUS" == "failed" ]]; then - printf "The x86_64 syscalls used by the worker binaries have changed. Please review if this is expected and update polkadot/scripts/list-syscalls/*-worker-syscalls as needed.\n"; + printf "The x86_64 syscalls used by the worker binaries have changed. Please review if this is expected and update polkadot/scripts/list-syscalls/*-worker-syscalls as needed.\n"; fi allow_failure: false # this rarely triggers in practice From 5a793cd3b1fd891931885f485768e3f52b20f2f4 Mon Sep 17 00:00:00 2001 From: alvicsam Date: Mon, 18 Dec 2023 12:44:06 +0100 Subject: [PATCH 2/4] add check --- .gitlab/pipeline/test.yml | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/.gitlab/pipeline/test.yml b/.gitlab/pipeline/test.yml index 848424b372a4..7c569b4074e7 100644 --- a/.gitlab/pipeline/test.yml +++ b/.gitlab/pipeline/test.yml @@ -303,9 +303,14 @@ node-bench-regression-guard: artifacts: true variables: CI_IMAGE: "paritytech/node-bench-regression-guard:latest" + # current git limit is 20, set to 100 to avoid failures (gitlab removes old artifacts) + GIT_LIMIT: 100 before_script: [""] script: - - ls -la artifacts/benches/ + - if [ $(ls -la artifacts/benches/ | grep master | wc -l) == 0 ]; then + echo "Couldn't find master artifacts, consider increasing GIT_LIMIT variable"; + exit 1; + fi - echo "------- IMPORTANT -------" - echo "node-bench-regression-guard depends on the results of a cargo-check-benches job" - echo "In case of this job failure, check your pipeline's cargo-check-benches" From 4796543c5917508e3bac006cf7287b3fe67f208f Mon Sep 17 00:00:00 2001 From: alvicsam Date: Mon, 18 Dec 2023 13:28:43 +0100 Subject: [PATCH 3/4] specify GIT_STRATEGY explicitly --- .gitlab/pipeline/test.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitlab/pipeline/test.yml b/.gitlab/pipeline/test.yml index 7c569b4074e7..9ba886ecfd8d 100644 --- a/.gitlab/pipeline/test.yml +++ b/.gitlab/pipeline/test.yml @@ -305,6 +305,7 @@ node-bench-regression-guard: CI_IMAGE: "paritytech/node-bench-regression-guard:latest" # current git limit is 20, set to 100 to avoid failures (gitlab removes old artifacts) GIT_LIMIT: 100 + GIT_STRATEGY: fetch before_script: [""] script: - if [ $(ls -la artifacts/benches/ | grep master | wc -l) == 0 ]; then From be1953f97888c7900aad45083a0dada667995b6d Mon Sep 17 00:00:00 2001 From: alvicsam Date: Mon, 18 Dec 2023 14:58:35 +0100 Subject: [PATCH 4/4] git_clone -> git_depth --- .gitlab/pipeline/test.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.gitlab/pipeline/test.yml b/.gitlab/pipeline/test.yml index 9ba886ecfd8d..bbe9b612bc37 100644 --- a/.gitlab/pipeline/test.yml +++ b/.gitlab/pipeline/test.yml @@ -304,7 +304,7 @@ node-bench-regression-guard: variables: CI_IMAGE: "paritytech/node-bench-regression-guard:latest" # current git limit is 20, set to 100 to avoid failures (gitlab removes old artifacts) - GIT_LIMIT: 100 + GIT_DEPTH: 100 GIT_STRATEGY: fetch before_script: [""] script: