From 416445d081cbd23e30e1d6311da2149d93cc72b2 Mon Sep 17 00:00:00 2001 From: Wilfried Kopp Date: Wed, 6 Sep 2023 10:28:12 +0200 Subject: [PATCH 01/11] Merge CODEOWNERS --- .github/CODEOWNERS | 73 ++++++++++++++++++++++++++++++++++++ cumulus/CODEOWNERS | 23 ------------ polkadot/.github/CODEOWNERS | 6 --- substrate/docs/CODEOWNERS | 74 ------------------------------------- 4 files changed, 73 insertions(+), 103 deletions(-) create mode 100644 .github/CODEOWNERS delete mode 100644 cumulus/CODEOWNERS delete mode 100644 polkadot/.github/CODEOWNERS delete mode 100644 substrate/docs/CODEOWNERS diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS new file mode 100644 index 000000000000..a2f8021478e5 --- /dev/null +++ b/.github/CODEOWNERS @@ -0,0 +1,73 @@ +# Lists some code owners. +# +# A codeowner just oversees some part of the codebase. If an owned file is changed then the +# corresponding codeowner receives a review request. An approval of the codeowner might be +# required for merging a PR (depends on repository settings). +# +# For details about syntax, see: +# https://help.github.com/en/articles/about-code-owners +# But here are some important notes: +# +# - Glob syntax is git-like, e.g. `/core` means the core directory in the root, unlike `core` +# which can be everywhere. +# - Multiple owners are supported. +# - Either handle (e.g, @github_user or @github/team) or email can be used. Keep in mind, +# that handles might work better because they are more recognizable on GitHub, +# eyou can use them for mentioning unlike an email. +# - The latest matching rule, if multiple, takes precedence. + +# CI +/.github/ @paritytech/ci @paritytech/release-engineering +/.gitlab-ci.yml @paritytech/ci +/scripts/ci/ @paritytech/ci @paritytech/release-engineering + + +# WASM executor, low-level client <-> WASM interface and other WASM-related code +/substrate/client/allocator/ @koute +/substrate/client/executor/ @koute +/substrate/primitives/panic-handler/ @koute +/substrate/primitives/runtime-interface/ @koute +/substrate/primitives/wasm-interface/ @koute +/substrate/utils/wasm-builder/ @koute + +# Systems-related bits and bobs on the client side +/substrate/client/sysinfo/ @koute +/substrate/client/tracing/ @koute + +# Documentation audit +/substrate/primitives/runtime @paritytech/docs-audit +/substrate/primitives/arithmetic @paritytech/docs-audit +# /primitives/core (to be added later) +# /primitives/io (to be added later) + +# FRAME +/substrate/frame/ @paritytech/frame-coders @paritytech/docs-audit +/substrate/frame/nfts/ @jsidorenko @paritytech/docs-audit +/substrate/frame/state-trie-migration/ @paritytech/frame-coders @cheme +/substrate/frame/uniques/ @jsidorenko @paritytech/docs-audit + +# GRANDPA, BABE, consensus stuff +/substrate/client/consensus/babe/ @andresilva +/substrate/client/consensus/grandpa/ @andresilva +/substrate/client/consensus/pow/ @sorpaas +/substrate/client/consensus/slots/ @andresilva +/substrate/frame/babe/ @andresilva +/substrate/frame/grandpa/ @andresilva +/substrate/primitives/consensus/pow/ @sorpaas + +# BEEFY, MMR +/substrate/frame/beefy/ @acatangiu +/substrate/frame/beefy-mmr/ @acatangiu +/substrate/frame/merkle-mountain-range/ @acatangiu +/substrate/primitives/merkle-mountain-range/ @acatangiu + +# Contracts +/substrate/frame/contracts/ @athei @paritytech/docs-audit + +# NPoS and election +/substrate/frame/election-provider-multi-phase/ @paritytech/staking-core @paritytech/docs-audit +/substrate/frame/election-provider-support/ @paritytech/staking-core @paritytech/docs-audit +/substrate/frame/elections-phragmen/ @paritytech/staking-core @paritytech/docs-audit +/substrate/frame/nomination-pools/ @paritytech/staking-core @paritytech/docs-audit +/substrate/frame/staking/ @paritytech/staking-core @paritytech/docs-audit +/substrate/primitives/npos-elections/ @paritytech/staking-core @paritytech/docs-audit diff --git a/cumulus/CODEOWNERS b/cumulus/CODEOWNERS deleted file mode 100644 index 3e5e8bd062dd..000000000000 --- a/cumulus/CODEOWNERS +++ /dev/null @@ -1,23 +0,0 @@ -# Lists some code owners. -# -# A codeowner just oversees some part of the codebase. If an owned file is changed then the -# corresponding codeowner receives a review request. An approval of the codeowner might be -# required for merging a PR (depends on repository settings). -# -# For details about syntax, see: -# https://help.github.com/en/articles/about-code-owners -# But here are some important notes: -# -# - Glob syntax is git-like, e.g. `/core` means the core directory in the root, unlike `core` -# which can be everywhere. -# - Multiple owners are supported. -# - Either handle (e.g, @github_user or @github/team) or email can be used. Keep in mind, -# that handles might work better because they are more recognizable on GitHub, -# eyou can use them for mentioning unlike an email. -# - The latest matching rule, if multiple, takes precedence. - -# CI -/.github/ @paritytech/ci @paritytech/release-engineering -/.gitlab-ci.yml @paritytech/ci -/scripts/ci/ @paritytech/ci @paritytech/release-engineering - diff --git a/polkadot/.github/CODEOWNERS b/polkadot/.github/CODEOWNERS deleted file mode 100644 index a92dc0bb006c..000000000000 --- a/polkadot/.github/CODEOWNERS +++ /dev/null @@ -1,6 +0,0 @@ -# CI -/.github/ @paritytech/ci @chevdor -/scripts/ci/ @paritytech/ci @chevdor -/.gitlab-ci.yml @paritytech/ci -# lingua.dic is not managed by CI team -/scripts/ci/gitlab/lingua.dic diff --git a/substrate/docs/CODEOWNERS b/substrate/docs/CODEOWNERS deleted file mode 100644 index 63294d90e9d0..000000000000 --- a/substrate/docs/CODEOWNERS +++ /dev/null @@ -1,74 +0,0 @@ -# Lists some code owners. -# -# A codeowner just oversees some part of the codebase. If an owned file is changed then the -# corresponding codeowner receives a review request. An approval of the codeowner is -# not required for merging a PR though. -# -# **This is pretty much an experiment at the moment**. Feel free to remove yourself at any time if -# you do not want to receive review requests any longer. -# -# For details about syntax, see: -# https://help.github.com/en/articles/about-code-owners -# But here are some important notes: -# -# - Glob syntax is git-like, e.g. `/core` means the core directory in the root, unlike `core` which -# can be everywhere. -# - Multiple owners are supported. -# - Either handle (e.g, @pepyakin) or email can be used. Keep in mind, that handles might work better because they -# are more recognizable on GitHub, you can use them for mentioning unlike an email. -# - The latest matching rule, if multiple, takes precedence. - -# CI -/.github/ @paritytech/ci -/.gitlab-ci.yml @paritytech/ci -/scripts/ci/ @paritytech/ci - -# WASM executor, low-level client <-> WASM interface and other WASM-related code -/client/allocator/ @koute -/client/executor/ @koute -/primitives/panic-handler/ @koute -/primitives/runtime-interface/ @koute -/primitives/wasm-interface/ @koute -/utils/wasm-builder/ @koute - -# Systems-related bits and bobs on the client side -/client/sysinfo/ @koute -/client/tracing/ @koute - -# Documentation audit -/primitives/runtime @paritytech/docs-audit -/primitives/arithmetic @paritytech/docs-audit -# /primitives/core (to be added later) -# /primitives/io (to be added later) - -# FRAME -/frame/ @paritytech/frame-coders @paritytech/docs-audit -/frame/nfts/ @jsidorenko @paritytech/docs-audit -/frame/state-trie-migration/ @paritytech/frame-coders @cheme -/frame/uniques/ @jsidorenko @paritytech/docs-audit - -# GRANDPA, BABE, consensus stuff -/client/consensus/babe/ @andresilva -/client/consensus/grandpa/ @andresilva -/client/consensus/pow/ @sorpaas -/client/consensus/slots/ @andresilva -/frame/babe/ @andresilva -/frame/grandpa/ @andresilva -/primitives/consensus/pow/ @sorpaas - -# BEEFY, MMR -/frame/beefy/ @acatangiu -/frame/beefy-mmr/ @acatangiu -/frame/merkle-mountain-range/ @acatangiu -/primitives/merkle-mountain-range/ @acatangiu - -# Contracts -/frame/contracts/ @athei @paritytech/docs-audit - -# NPoS and election -/frame/election-provider-multi-phase/ @paritytech/staking-core @paritytech/docs-audit -/frame/election-provider-support/ @paritytech/staking-core @paritytech/docs-audit -/frame/elections-phragmen/ @paritytech/staking-core @paritytech/docs-audit -/frame/nomination-pools/ @paritytech/staking-core @paritytech/docs-audit -/frame/staking/ @paritytech/staking-core @paritytech/docs-audit -/primitives/npos-elections/ @paritytech/staking-core @paritytech/docs-audit From d86370459bbbfdda12bdce6c50c96701b984c314 Mon Sep 17 00:00:00 2001 From: Wilfried Kopp Date: Wed, 6 Sep 2023 10:49:56 +0200 Subject: [PATCH 02/11] Add top levels catch-all --- .github/CODEOWNERS | 15 +++++++++++++-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index a2f8021478e5..af31249ffaf9 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -16,12 +16,23 @@ # eyou can use them for mentioning unlike an email. # - The latest matching rule, if multiple, takes precedence. -# CI +# Top levels +/docker @paritytech/ci @paritytech/release-engineering +/prdoc @paritytech/release-engineering +/docs @paritytech/docs-audit +/substrate @paritytech/SubstrateTeamLeads +/polkadot @paritytech/polkadot-review +/cumulus @paritytech/cumulus-locks-review +.rustfmt.toml @paritytech/core-devs +Cargo.toml @paritytech/core-devs +*.md @paritytech/docs-audit + +# CI / Releng /.github/ @paritytech/ci @paritytech/release-engineering /.gitlab-ci.yml @paritytech/ci +/.gitlab/ @paritytech/ci /scripts/ci/ @paritytech/ci @paritytech/release-engineering - # WASM executor, low-level client <-> WASM interface and other WASM-related code /substrate/client/allocator/ @koute /substrate/client/executor/ @koute From 295a36f010f5542b648461e15b340102e490b018 Mon Sep 17 00:00:00 2001 From: Wilfried Kopp Date: Wed, 6 Sep 2023 10:53:15 +0200 Subject: [PATCH 03/11] Order the list --- .github/CODEOWNERS | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index af31249ffaf9..19f5e455f882 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -28,10 +28,12 @@ Cargo.toml @paritytech/core-devs *.md @paritytech/docs-audit # CI / Releng -/.github/ @paritytech/ci @paritytech/release-engineering +/.github @paritytech/ci @paritytech/release-engineering /.gitlab-ci.yml @paritytech/ci -/.gitlab/ @paritytech/ci -/scripts/ci/ @paritytech/ci @paritytech/release-engineering +/.gitlab @paritytech/ci +/scripts/ci @paritytech/ci @paritytech/release-engineering +/.config @paritytech/ci +/.cargo @paritytech/ci # WASM executor, low-level client <-> WASM interface and other WASM-related code /substrate/client/allocator/ @koute From c89f54001b0c9e964ae733cd3e325aa0b7772b7d Mon Sep 17 00:00:00 2001 From: Wilfried Kopp Date: Wed, 6 Sep 2023 11:23:22 +0200 Subject: [PATCH 04/11] Sort the list --- .github/CODEOWNERS | 21 ++++++++++----------- 1 file changed, 10 insertions(+), 11 deletions(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 19f5e455f882..327a3977005b 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -17,24 +17,23 @@ # - The latest matching rule, if multiple, takes precedence. # Top levels +/.cargo @paritytech/ci +/.config @paritytech/ci +/.github @paritytech/ci @paritytech/release-engineering +/.gitlab @paritytech/ci +/cumulus @paritytech/cumulus-locks-review /docker @paritytech/ci @paritytech/release-engineering -/prdoc @paritytech/release-engineering /docs @paritytech/docs-audit -/substrate @paritytech/SubstrateTeamLeads /polkadot @paritytech/polkadot-review -/cumulus @paritytech/cumulus-locks-review +/scripts/ci @paritytech/ci @paritytech/release-engineering +/substrate @paritytech/SubstrateTeamLeads +/prdoc @paritytech/release-engineering + +.gitlab-ci.yml @paritytech/ci .rustfmt.toml @paritytech/core-devs Cargo.toml @paritytech/core-devs *.md @paritytech/docs-audit -# CI / Releng -/.github @paritytech/ci @paritytech/release-engineering -/.gitlab-ci.yml @paritytech/ci -/.gitlab @paritytech/ci -/scripts/ci @paritytech/ci @paritytech/release-engineering -/.config @paritytech/ci -/.cargo @paritytech/ci - # WASM executor, low-level client <-> WASM interface and other WASM-related code /substrate/client/allocator/ @koute /substrate/client/executor/ @koute From 17562f1563217ed9384d127ebc9e5cae0ff99933 Mon Sep 17 00:00:00 2001 From: Wilfried Kopp Date: Wed, 6 Sep 2023 11:31:14 +0200 Subject: [PATCH 05/11] Add finer patterns for cumulus --- .github/CODEOWNERS | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 327a3977005b..93525f9a7eb8 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -83,3 +83,7 @@ Cargo.toml @paritytech/core-devs /substrate/frame/nomination-pools/ @paritytech/staking-core @paritytech/docs-audit /substrate/frame/staking/ @paritytech/staking-core @paritytech/docs-audit /substrate/primitives/npos-elections/ @paritytech/staking-core @paritytech/docs-audit + +# Cumulus +/cumulus/xcm/xcm-emulator @nachopal +/cumulus/parachains/integration-tests @nachopal From 16dca98b778b5508990e9037fee9ff67d4831ba6 Mon Sep 17 00:00:00 2001 From: Wilfried Kopp Date: Wed, 6 Sep 2023 11:36:53 +0200 Subject: [PATCH 06/11] Add top level pattern for bridges --- .github/CODEOWNERS | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 93525f9a7eb8..5103da47a056 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -21,6 +21,7 @@ /.config @paritytech/ci /.github @paritytech/ci @paritytech/release-engineering /.gitlab @paritytech/ci +/bridges @paritytech/bridges-core /cumulus @paritytech/cumulus-locks-review /docker @paritytech/ci @paritytech/release-engineering /docs @paritytech/docs-audit From b61b49e6923c014a79f3d7c8124611b1d37fcd77 Mon Sep 17 00:00:00 2001 From: Wilfried Kopp Date: Wed, 6 Sep 2023 11:38:42 +0200 Subject: [PATCH 07/11] Add core-devs to cumulus --- .github/CODEOWNERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 5103da47a056..c0bb69af0b28 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -22,7 +22,7 @@ /.github @paritytech/ci @paritytech/release-engineering /.gitlab @paritytech/ci /bridges @paritytech/bridges-core -/cumulus @paritytech/cumulus-locks-review +/cumulus @paritytech/cumulus-locks-review @paritytech/core-devs /docker @paritytech/ci @paritytech/release-engineering /docs @paritytech/docs-audit /polkadot @paritytech/polkadot-review From ceb81be3c905e81d29e6b5cf000fe6ae6ccf66e7 Mon Sep 17 00:00:00 2001 From: Chevdor Date: Wed, 6 Sep 2023 12:09:58 +0200 Subject: [PATCH 08/11] Update .github/CODEOWNERS Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com> --- .github/CODEOWNERS | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index c0bb69af0b28..9d42bed8c687 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -12,8 +12,8 @@ # which can be everywhere. # - Multiple owners are supported. # - Either handle (e.g, @github_user or @github/team) or email can be used. Keep in mind, -# that handles might work better because they are more recognizable on GitHub, -# eyou can use them for mentioning unlike an email. +# that handles might work better because they are more recognizable on GitHub +# and you can use them for mentioning unlike an email. # - The latest matching rule, if multiple, takes precedence. # Top levels From 9433404740eaf783ab880852752e5cad5934b958 Mon Sep 17 00:00:00 2001 From: Chevdor Date: Thu, 7 Sep 2023 17:03:50 +0200 Subject: [PATCH 09/11] Add rules for networking to .github/CODEOWNERS Co-authored-by: Aaro Altonen <48052676+altonen@users.noreply.github.com> --- .github/CODEOWNERS | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 9d42bed8c687..6b016b13efca 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -53,6 +53,9 @@ Cargo.toml @paritytech/core-devs # /primitives/core (to be added later) # /primitives/io (to be added later) +# Networking-related code +/substrate/client/network @paritytech/networking + # FRAME /substrate/frame/ @paritytech/frame-coders @paritytech/docs-audit /substrate/frame/nfts/ @jsidorenko @paritytech/docs-audit From 294528eff9799613c17848dffc973a0cca78eb4f Mon Sep 17 00:00:00 2001 From: Francisco Aguirre Date: Fri, 8 Sep 2023 11:39:36 -0300 Subject: [PATCH 10/11] Add the XCM team as owner of /polkadot/xcm --- .github/CODEOWNERS | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 6b016b13efca..5268b676810b 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -26,6 +26,7 @@ /docker @paritytech/ci @paritytech/release-engineering /docs @paritytech/docs-audit /polkadot @paritytech/polkadot-review +/polkadot/xcm @paritytech/xcm /scripts/ci @paritytech/ci @paritytech/release-engineering /substrate @paritytech/SubstrateTeamLeads /prdoc @paritytech/release-engineering From e50e9e1cc2f29506cb486ae45c114f9216f410e4 Mon Sep 17 00:00:00 2001 From: Adrian Catangiu Date: Fri, 8 Sep 2023 17:51:03 +0300 Subject: [PATCH 11/11] Update .github/CODEOWNERS --- .github/CODEOWNERS | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 5268b676810b..236e0d29b9ae 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -65,6 +65,7 @@ Cargo.toml @paritytech/core-devs # GRANDPA, BABE, consensus stuff /substrate/client/consensus/babe/ @andresilva +/substrate/client/consensus/beefy/ @acatangiu /substrate/client/consensus/grandpa/ @andresilva /substrate/client/consensus/pow/ @sorpaas /substrate/client/consensus/slots/ @andresilva