Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pallet-assets sufficient assets ED should provide same benefits as DOT ED #5298

Open
acatangiu opened this issue Aug 9, 2024 · 1 comment
Labels
T1-FRAME This PR/Issue is related to core FRAME, the framework. T2-pallets This PR/Issue is related to a particular pallet.

Comments

@acatangiu
Copy link
Contributor

Holding a sufficient pallet-assets asset satisfying ED, should allow that account to also receive other assets (in technical terms, it should be an account provider).

Example scenario: on AssetHub if an account holds USDT/USDC (enough to cover ED), it should be able to receive/hold other assets too, without necessarily having to also hold DOT ED (as it requires now).

This is not possible now though because pallet-assets "sufficient" assets do not act as account providers.

Here is a branch with minimal repro of the issue (very simple unit-test), diff against master here.

@acatangiu acatangiu added T1-FRAME This PR/Issue is related to core FRAME, the framework. T2-pallets This PR/Issue is related to a particular pallet. labels Aug 9, 2024
@acatangiu
Copy link
Contributor Author

I looked into changing pallet-assets to add inc_providers() alongside inc_sufficients(), but then the current logic for killing accounts (defined as (asset, account) pair) doesn't really support failing to kill sufficient when consumers > 0 (aka not allow USDT withdraw if it is sole account "provider" for other existing (asset, account) pairs).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T1-FRAME This PR/Issue is related to core FRAME, the framework. T2-pallets This PR/Issue is related to a particular pallet.
Projects
None yet
Development

No branches or pull requests

1 participant