Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bench-bot: compare against https://github.com/paritytech/bench-bot #54

Closed
joao-paulo-parity opened this issue Jun 30, 2022 · 0 comments
Closed
Assignees

Comments

@joao-paulo-parity
Copy link
Contributor

joao-paulo-parity commented Jun 30, 2022

command-bot queues bench-bot commands to GitLab's Shell Executors, the same approach used for calculating weights before releases (https://github.com/paritytech/polkadot/blob/eb21d7c8c25547826240d10a060291599aab18e5/.gitlab-ci.yml#L522), which means that commands are executed directly in the host's shell, therefore performance should remain "bare metal". For a demo see paritytech/substrate#11566 (comment).

The new syntax is explained in #63.

The new implementation of bench-bot is decoupled from command-bot and lives in https://github.com/paritytech/pipeline-scripts/blob/master/bench-bot.sh; any updates made to that script will be effective immediately for future commands, without having to redeploy command-bot.

Other notable differences are:

Some planned tickets from https://github.com/paritytech/bench-bot/issues were copied or moved to this repository: https://github.com/paritytech/pipeline-scripts/issues?q=is%3Aissue+is%3Aopen+bench-bot+created%3A%3C%3D2022-06-30. If you find that some important ticket was not brought over or not implemented already, feel free to create a new ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant