This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Naive chunk creation, snapshotting #1263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arkpar
added
the
A3-inprogress ⏳
|
this specific PR is not in-progress. to avoid change size getting out of hand it is better to split it up into smaller, more easily reviewable chunks IMO. |
rphmeier
removed
the
A3-inprogress ⏳
|
|
||
| // lock the state db while we create the state chunks. | ||
| let state_hashes = { | ||
| let state_db = self.state_db.lock().unwrap(); |
There was a problem hiding this comment.
StateDB should not be locked for the whole duration, use a clone like this:
let db = self.state_db.lock().unwrap().boxed_clone();There was a problem hiding this comment.
i had been under the impression that it was necessary for a proper snapshot. our conversation has mitigated these worries.
|
I'd avoid "pv64" name in the code, this is just a protocol version that can change. |
gavofyork
added
A8-looksgood 🦄
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cannot be merged into master yet. It requires a DB upgrade/migration. Work will continue in the pv64 branch here, as well as my local pv64 branch. Opening the code to review so we can discuss design improvements, issues, and the way forward.