-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Conversation
let queue = self.transaction_queue.lock().unwrap(); | ||
queue.find(hash) | ||
} | ||
} | ||
} | ||
|
||
fn pending_transactions(&self) -> Vec<SignedTransaction> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pending transactions is used also when propagating transactions - does it mean that we don't want to propagate everything from queue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All valid transactions should be propogated
doesn't actually work according to spec - watched |
so that was never ratified by me. fabian added it unilaterally on July 7, 2015 in https://github.com/ethereum/wiki/wiki/JSON-RPC/_compare/f5d8c9d4c99cd3a4502eba1384e19244e1bf0e0d...88b78a4cb70ccf401c088b928365c87de45064f5 almost certainly just proscribing based on geth's behaviour. cpp-ethereum did provide pending receipts (since they're rather useful). |
yes :/ And I don't know if we should change this, cause there might be a code relying this behaviour |
we'll do our own |
still broken. gets called multiple times as the client syncs new blocks. |
it should be called once and only once when:
rarer events that should also be supported:
also, |
fixes querying pending in most cases except:
eth_getTransactionReceipt
, cause the docs stateNote That the receipt is not available for pending transactions.
.