-
Notifications
You must be signed in to change notification settings - Fork 8
Companion failed to merge with "Failed to parse lockfile of polkadot" error #392
Comments
The full error from paritytech/polkadot#5731 (comment)
It happened in parity-processbot/src/companion.rs Line 104 in 2feca9b
cargo_lock . From a quick look at cargo_lock 's source code (https://github.com/rustsec/rustsec/tree/main/cargo-lock) I couldn't understand why this error happens. It's strange since dependency resolution is cargo's job and I was expecting cargo_lock to only be parsing the file, but apparently it does more.
On another note I've recently found out that Using |
Ok, I think I figured it out. The problem is that the lockfile had two windows-sys
It was incorrect when the bot tried to merge it since the link in https://github.com/koute/polkadot/blob/8ff2627f00c88e5f0997b44f444b67d3a83d3444/Cargo.lock#L6054 doesn't correctly specify which version to use. And the follow-up commit had to fix that in paritytech/polkadot@2abfa1c#diff-13ee4b2252c9e516a0547f2891aa2105c3ca71c6d7a1e682c69be97998dfc87eR6054. Therefore the problem in that case wasn't with the bot, it was with the commit itself. That problem should've been caught by the integration checks on CI, so I've created paritytech/pipeline-scripts#61 for this. Closing since this isn't a processbot bug. |
The problems mentioned here might have a solution in the future as per rustsec/rustsec#606, but it relies on |
Originally posted in github.com/paritytech by @koute
The text was updated successfully, but these errors were encountered: