Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for BorshDeserialize and BorshSerialize #640

Open
ivanceras opened this issue Apr 2, 2022 · 5 comments
Open

Support for BorshDeserialize and BorshSerialize #640

ivanceras opened this issue Apr 2, 2022 · 5 comments

Comments

@ivanceras
Copy link

Hi, is there any plan to support BorshSerialize and BorshDeserialize for the ethereum-types.
I notice that borsh is used in NEAR and in Solana which provides compatibility with ethereum.

@ordian
Copy link
Member

ordian commented Apr 11, 2022

Hey @ivanceras. If there's enough demand for it, we might consider adding this feature. However, that would mean tying any major releases to a breaking change to ethereum-types, which we'd like to avoid.

@sloboste
Copy link

sloboste commented Dec 1, 2022

Borsh support would be useful to hyperlane and eclipse.

@ordian to address your concern about avoiding being tied to breaking changes - given that borsh is still in 0.x, what do you think about feature gating borsh support behind an experimental-impl-borsh feature and documenting explicitly that there may be breaking changes to anything related to borsh?

@ordian
Copy link
Member

ordian commented Feb 1, 2023

@sloboste hey, sorry for the long delay in reply. I think your suggestion is a reasonable workaround we can live with.

@tkporter
Copy link

tkporter commented May 4, 2023

@ordian would love to see #698 get merged with the feature gate :) are there any changes you'd like to see there?

@ordian
Copy link
Member

ordian commented May 4, 2023

@tkporter yes, see point 2 in #698 (comment). Instead of introducing a new crate with a regular macro, we could just use derive with a feature gate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants