From 4632f260c0e212973eac6fe25c1d9c4a8aa8a426 Mon Sep 17 00:00:00 2001 From: Dmitry Markin Date: Wed, 7 Aug 2024 14:44:25 +0000 Subject: [PATCH] Fix TCP, WS, QUIC leaking connection ids in `reject()` --- src/transport/quic/mod.rs | 1 - src/transport/tcp/mod.rs | 1 - src/transport/websocket/mod.rs | 1 - 3 files changed, 3 deletions(-) diff --git a/src/transport/quic/mod.rs b/src/transport/quic/mod.rs index d0ac2375..58e06832 100644 --- a/src/transport/quic/mod.rs +++ b/src/transport/quic/mod.rs @@ -285,7 +285,6 @@ impl Transport for QuicTransport { } fn reject(&mut self, connection_id: ConnectionId) -> crate::Result<()> { - self.canceled.insert(connection_id); self.pending_open .remove(&connection_id) .map_or(Err(Error::ConnectionDoesntExist(connection_id)), |_| Ok(())) diff --git a/src/transport/tcp/mod.rs b/src/transport/tcp/mod.rs index 9eb24d40..ccfb9bec 100644 --- a/src/transport/tcp/mod.rs +++ b/src/transport/tcp/mod.rs @@ -310,7 +310,6 @@ impl Transport for TcpTransport { } fn reject(&mut self, connection_id: ConnectionId) -> crate::Result<()> { - self.canceled.insert(connection_id); self.pending_open .remove(&connection_id) .map_or(Err(Error::ConnectionDoesntExist(connection_id)), |_| Ok(())) diff --git a/src/transport/websocket/mod.rs b/src/transport/websocket/mod.rs index cc2e3740..eae7e3e8 100644 --- a/src/transport/websocket/mod.rs +++ b/src/transport/websocket/mod.rs @@ -379,7 +379,6 @@ impl Transport for WebSocketTransport { } fn reject(&mut self, connection_id: ConnectionId) -> crate::Result<()> { - self.canceled.insert(connection_id); self.pending_open .remove(&connection_id) .map_or(Err(Error::ConnectionDoesntExist(connection_id)), |_| Ok(()))