Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move host filtering to a tower layer #868

Closed
lexnv opened this issue Aug 30, 2022 · 1 comment · Fixed by #1179
Closed

Move host filtering to a tower layer #868

lexnv opened this issue Aug 30, 2022 · 1 comment · Fixed by #1179

Comments

@lexnv
Copy link
Contributor

lexnv commented Aug 30, 2022

We have an access control filtering that verifies both the host and origin.

ACL requires the host to be present in the headers, while the origin is optional.
Both values are checked against an allow list, if they are not present in the allow list the
request is denied.

However, for HTTP 2.0 the host is part of the request's uri, see #866.

Move the access control filtering to a tower layer to make this feature optional.

@niklasad1 niklasad1 changed the title Move access control filtering to a tower layer Move host filtering to a tower layer Sep 20, 2022
@niklasad1
Copy link
Member

niklasad1 commented Sep 20, 2022

Previously we had some something called AccessControl which did:

  • CORS / origin filtering
  • host filtering

The CORS part has been moved to tower http middleware so we don't have to bother with that anymore and a bunch of opinionated "white/blacklisted" headers.

The access control API is just called host filtering now which is the same as @lexnv stated ☝️ which could be implemented as tower middleware as well to make it optional.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants