Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[proc macros]: improve is_optionhelper #447

Closed
niklasad1 opened this issue Sep 1, 2021 · 2 comments
Closed

[proc macros]: improve is_optionhelper #447

niklasad1 opened this issue Sep 1, 2021 · 2 comments

Comments

@niklasad1
Copy link
Member

niklasad1 commented Sep 1, 2021 •
edited
Loading

The implementation is a bit naive and should investigated and tested further.

Not sure why anybody would, but it may also be useful to test that std::option::Option works, and maybe test that something stupid like foo::Option::Bar doesn't work?

Originally posted by @jsdw in #446 (comment)
@dvdplm
Copy link
Contributor

dvdplm commented Sep 1, 2021

Both std::option::Option and core::option::Option should work. And then there's the pesky issue of re-exports. Some crates re-export parts of std/core.

@niklasad1
Copy link
Member Author

Fixed by #441

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dvdplm @niklasad1