Fix Greeter and run documentation tests in CI
#773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The contract build will fail otherwise due to the usage of `std::string::String` because of `std::format`.
Codecov Report
@@ Coverage Diff @@
## master #773 +/- ##
===========================================
- Coverage 83.39% 67.48% -15.91%
===========================================
Files 163 163
Lines 7502 7502
===========================================
- Hits 6256 5063 -1193
- Misses 1246 2439 +1193
Continue to review full report at Codecov.
|
The CI run already takes quite long and I don't think it makes that much difference if we reduce the amount of runs. The bugs we catched so far were always catched with way less runs than even this new number.
Robbepop
reviewed
Apr 21, 2021
Robbepop
approved these changes
Apr 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Greeterwas not working in it's current stage.Note that even though
cargo test --doc --workspaceimproves our testing, it would still not have catched theGreetererror which this PR fixes.I'll create follow-ups for
ink-docsand the workshop, which are also missinguse ink_prelude::format.