-
Notifications
You must be signed in to change notification settings - Fork 447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unique trait id as a parameter for CallBuilder
trait impls
#1141
Unique trait id as a parameter for CallBuilder
trait impls
#1141
Conversation
CallBuilder
trait implsCallBuilder
trait impls
CallBuilder
trait implsCallBuilder
trait impls
CallBuilder
trait implsCallBuilder
trait impls
🦑 📈 ink! Example Contracts ‒ Changes Report 📉 🦑These are the results when building the
Link to the run | Last update: Fri Feb 18 18:43:11 CET 2022 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm okay with all three changes=) But between second and third I prefer third=)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, this is my preferred solution as well!
Co-authored-by: Hernando Castano <HCastano@users.noreply.github.com>
Co-authored-by: Hernando Castano <HCastano@users.noreply.github.com>
Co-authored-by: Hernando Castano <HCastano@users.noreply.github.com>
Co-authored-by: Hernando Castano <HCastano@users.noreply.github.com>
Co-authored-by: Hernando Castano <HCastano@users.noreply.github.com>
Yet another solution for #982, as an alternative to #983 and #1136.
It is similar to #1136 except that it uses a unique id generated for the trait an by XOR of the trait selectors, which should be unique. As suggested by @xgreenx.