Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

unique breaking changes #1132

Closed
gilescope opened this issue Apr 1, 2022 · 1 comment · Fixed by #1133
Closed

unique breaking changes #1132

gilescope opened this issue Apr 1, 2022 · 1 comment · Fixed by #1133
Labels
T7-system_parachains This PR/Issue is related to System Parachains.

Comments

@gilescope
Copy link
Contributor

I'm not sure this is a big deal, but hex-encoded call:

0x33016501008eaf04151687736326c9fea17e25fc5287613693c912909cb226aa4794f26a4801

encoded call details
callIndex	3301
class	6501
owner	00 8eaf04151687736326c9fea17e25fc5287613693c912909cb226aa4794f26a48
freeHolding	01

if you decode it in statemine/t v800 and below return a class of 89. If you decode it in v900 because it's now not a compact u32 but a u32 encoding, it means that the cleass is 2382365029 rather than 89

encoded call details
callIndex	3301
class	6501008e
owner	00 af04151687736326c9fea17e25fc5287613693c912909cb226aa4794f26a4801
freeHolding	00

This is due to removing compressed in the class here: paritytech/substrate#10896

I think because of this we should probably be bumping the transaction version in the next statemine/t release.

@gilescope gilescope added this to the statemint-v9.0.0 milestone Apr 1, 2022
@gilescope
Copy link
Contributor Author

"NOTE: This changes the transaction format." - ok Gav and I are agreed on that then.

@hbulgarini hbulgarini added the T7-system_parachains This PR/Issue is related to System Parachains. label Apr 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T7-system_parachains This PR/Issue is related to System Parachains.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants