bot fmt

[kianenigma]

should trigger a cargo +nightly fmt on the codebase and push back.

[joao-paulo-parity]

It could be implemented in processbot since we already have bot rebase afterall, but going forward I think it makes a lot of sense to create a script for this in https://github.com/paritytech/pipeline-scripts with a matching configuration for that script in command-bot (https://github.com/paritytech/command-bot#pull-request-commands), maybe with a syntax which is not as noisy e.g. /cmd fmt or something along those lines.

Using command-bot has another benefit: we'll use whatever's the latest CI image to format the project, which is guaranteed to be aligned with the CI checks, as opposed to formatting through processbot's toolchain which might become outdated in case the bot isn't restarted after the CI image is updated.

We plan for command-bot to become "the general bot command" while processbot remains focused on the merging automation. This request inspired me to create paritytech/parity-processbot#396 which reinforces this idea.

For the time being I'll move this ticket to command-bot since it fits better there.

[kianenigma]

Totally, I actually opened the issue in a wrong place. This belongs to command-bot.

[kianenigma]

Just to make sure I understood your comment, we can't do it already in command-bot, right?

[joao-paulo-parity]

Just to make sure I understood your comment, we can't do it already in command-bot, right?

You "can't do" in the sense that the command is not available at the moment, but it's possible to implement it. The fmt configuration does not exist yet since we only have bench-bot and try-runtime configurations as advertised in https://github.com/paritytech/command-bot#pull-request-command-queue.

To create that command we'd do the following

1. Create an fmt.sh script in https://github.com/paritytech/pipeline-scripts which formats the code an pushes it to the branch

• https://github.com/paritytech/pipeline-scripts/blob/892d12e234a62bab6a5c3338ddb1361cbda93a06/bench-bot.sh#L224 can be used as reference for the push

2. Add fmt to commandsConfiguration

   command-bot/src/core.ts

   Line 25 in 496391d

   export const commandsConfiguration: {

   which calls the fmt.sh script, the same way that

   command-bot/src/core.ts

   Line 34 in 496391d

   commandStart: ['"$PIPELINE_SCRIPTS_DIR/try-runtime-bot.sh"'],

   works

• This step might not be necessary in the future as per Make it possible to update command configurations without redeploying #60 (comment)

3. Use the command as /cmd queue -c fmt (or create a /cmd fmt alias for it?)

[mordamax]

Test:
paritytech/substrate#11964
✅ Fixed formatting paritytech/substrate@cc0ef5d

however the command-bot probably doesn't expect us to not pass arguments
so it fails with /cmd queue -c fmt or /cmd queue -c fmt $
while /cmd queue -c fmt $ 1 works, the usage is weird

Filed: #96 to fix this weird thing

[bkchr]

All of this syntax is very weird. Honestly, I don't care what 1000 bots we got, the syntax should be simple.

A simple bot fmt should it be and not any /cmd queue -c fmt.

Can we not just merge bots or make on general thing that reacts to "bot" and then call the appropriate functionality?

[mordamax]

@bkchr thanks for feedback, I feel your pain. As JP mentioned (or create a /cmd fmt alias for it?) of course we can and we need to simplify and this. I filed #97 which will also list all available ~1000 commands along with simple aliases

[bkchr]

Still find it weird that there is some difference between bot and /cmd. Why not have one command for all?

[mordamax]

@bkchr sorry what bot do you mean? are you talking about bot merge ?

[bkchr]

Sorry, I meant some common prefix. Aka instead of having a wide variety of different ways to call different bots, some common prefix would be nice. Something like:

bot merge
bot rebase
bot fmt
bot try-runtime
bot bench --pallet pallet

Currently the last two for example are completely different command syntaxes.

[mordamax]

yep, that's what command-bot will be essentially.
Remember the try-runtime and benchbot was running differently with separate commands, now they all go through /cmd queue -c [command-name] $ ...arguments
now instead of going to add bot fmt which would be part of old processbot, it is part of command-bot, which will be one entry point for all types of commands

/cmd queue -c bench $ ...
/cmd queue -c try-runtime $ ...
/cmd queue -c fmt $ ...
etc..
and who knows, may be bot merge and bot rebase will be migrated here too

the problem is clear though - the syntax :) and there is a remedy for it #97 💊

[mordamax]

Closing this meanwhile, as technically it's possible to run, improvements to syntax will be followed up in upcoming issues