Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dynamic types support #1399

Merged
merged 34 commits into from
Nov 23, 2023
Merged

Add dynamic types support #1399

merged 34 commits into from
Nov 23, 2023

Conversation

smiasojed
Copy link
Collaborator

@smiasojed smiasojed commented Nov 13, 2023

Summary

Related #1168

  • [n] y/n | Does it introduce breaking changes?
  • [n] y/n | Is it dependent on the specific version of ink or pallet-contracts?
    Add dynamic types support

Description

Remove the need for compile-time node metadata stored in extrinsics/src/runtime_api/metadata.scale, and update the subxt setup to utilize dynamic values instead of static.
Note that the metadata is retained solely for testing purposes.

Checklist before requesting a review

  • [y] My code follows the style guidelines of this project
  • [y] I have added an entry to CHANGELOG.md
  • [y] I have commented my code, particularly in hard-to-understand areas
  • [n] I have added tests that prove my fix is effective or that my feature works
  • [n] Any dependent changes have been merged and published in downstream modules

@smiasojed smiasojed marked this pull request as ready for review November 15, 2023 14:51
Copy link
Collaborator

@ascjones ascjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we put all type definitions and constructors for extrinsics and storage keys etc. together in a single module?

The raw subxt stuff is better encapsulated, and it will be easier once we need to have multiple definitions for different versions.

crates/extrinsics/src/runtime_api/metadata_v15.scale Outdated Show resolved Hide resolved
crates/extrinsics/src/call.rs Outdated Show resolved Hide resolved
crates/extrinsics/src/instantiate.rs Outdated Show resolved Hide resolved
crates/build/Cargo.toml Outdated Show resolved Hide resolved
@smiasojed smiasojed merged commit ef90375 into master Nov 23, 2023
11 checks passed
@smiasojed smiasojed deleted the sm/dynamic branch November 23, 2023 09:24
@smiasojed smiasojed mentioned this pull request Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants