Show Gas consumption by default for dry-runs #1121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexD10S
requested review from
cmichi,
ascjones,
HCastano and
SkymanOne
as code owners
ascjones
reviewed
May 19, 2023
| @@ -467,6 +467,11 @@ impl InstantiateDryRunResult { | |||
| DEFAULT_KEY_COL_WIDTH | |||
| ); | |||
| name_value_println!("Data", format!("{:?}", self.data), DEFAULT_KEY_COL_WIDTH); | |||
| name_value_println!( | |||
| "Gas limit", | |||
There was a problem hiding this comment.
Suggested change
| "Gas limit", | |
| "Gas consumed", |
It is true that this value is used for the gas limit for transactions. But it is still the Gas consumed by the dry-run. Does it fit with the max col width?
There was a problem hiding this comment.
Yes, it still fits the width
ascjones
approved these changes
May 19, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify the output in
cargo contract instantiateto show the gas consumed estimated when dry-run.Fix the issue #1021
Output:
