Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scheduled email doesn't finish sending when edited. #612

Open
williamhrs opened this issue Jan 14, 2025 · 4 comments
Open

Scheduled email doesn't finish sending when edited. #612

williamhrs opened this issue Jan 14, 2025 · 4 comments

Comments

@williamhrs
Copy link

We found a weird bug happening when we edit an already scheduled e-mail.

It doesn't get fully sent, it only sends to some users and the others get aborted.

Let's say i just scheduled an email now, for tomorrow 9am(account timezone). I forgot to add a list, I edit it and save it again.

image
image

@pushchris
Copy link
Contributor

@williamhrs this may be working as expected but its hard to know. When you abort a campaign it marks 100% of the people who were supposed to receive the message and who have not yet been sent a message as aborted to prevent any more sends. If you then reschedule the campaign, it will regenerate a list and any users who were aborted and are now in the new send list will have their status changed back to pending, but the rest will stay in the aborted state. It does not clear out users who do not match the new send list since it's trying to record the total state of the campaign.

If as you said all you did was add a list that is a bit odd. The only thing I can think of is that the campaign was in the process of aborting when you rescheduled so the two queries were executing over each other? Was there a list changed or removed?

@williamhrs
Copy link
Author

@pushchris the thing is the email was never aborted on our side, only edited after it was scheduled. Is that what you said?

@williamhrs
Copy link
Author

even when you re schedule a campaign it doesn't work.

@pushchris
Copy link
Contributor

Interesting, looks like we didn't account for a case in the UI. You technically cant edit the base details of a campaign without aborting and restarting it since it needs to completely regenerate the send list. It looks like the UI lets you do that which puts the whole campaign into a bit of an odd state which it should ever be in. The design, etc can be edited while sending since those aren't related to the list or what sender things will go to. If you need to modify who an email is going to, abort it and then resend it. It will only send to those who haven't received it yet and should completely rebuild who receives the message (including the new additions)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants