From 9ae169ab80dd60592055783c0a3d84c74b775f9d Mon Sep 17 00:00:00 2001 From: Muhammad Abdullah Date: Fri, 18 Jan 2019 15:19:24 +0500 Subject: [PATCH] fix-dependency-tag-with-empty-value Solves https://github.com/parcel-bundler/parcel/issues/2528 --- .../core/parcel-bundler/src/assets/HTMLAsset.js | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/packages/core/parcel-bundler/src/assets/HTMLAsset.js b/packages/core/parcel-bundler/src/assets/HTMLAsset.js index e2646c7fbee..65b6a559b31 100644 --- a/packages/core/parcel-bundler/src/assets/HTMLAsset.js +++ b/packages/core/parcel-bundler/src/assets/HTMLAsset.js @@ -168,18 +168,25 @@ class HTMLAsset extends Asset { } for (let attr in node.attrs) { - let elements = ATTRS[attr]; + const attrVal = node.attrs[attr]; + + if (!attrVal) { + continue; + } + // Check for virtual paths - if (node.tag === 'a' && node.attrs[attr].lastIndexOf('.') < 1) { + if (node.tag === 'a' && attrVal.lastIndexOf('.') < 1) { continue; } + let elements = ATTRS[attr]; + if (elements && elements.includes(node.tag)) { let depHandler = this.getAttrDepHandler(attr); let options = OPTIONS[node.tag]; node.attrs[attr] = depHandler.call( this, - node.attrs[attr], + attrVal, options && options[attr] ); this.isAstDirty = true;