Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always close key handle if key is persistent #26

Closed
sbailey-arm opened this issue Jun 10, 2020 · 3 comments
Closed

Always close key handle if key is persistent #26

sbailey-arm opened this issue Jun 10, 2020 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@sbailey-arm
Copy link
Contributor

Currently handles for persistent keys are kept open after generating and importing, which causes mbedtls to run out of key slots.

If a key is persistent, its handle should be closed after each generate and import operation.

Only set the handle field if the key is volatile.

@hug-dev hug-dev added the enhancement New feature or request label Jun 10, 2020
@hug-dev
Copy link
Member

hug-dev commented Jun 10, 2020

Seems like a good thing to add to me!
Could you please also add an integration test where a big number of persistent keys are generated with both import and generate to see that it works?

@sbailey-arm
Copy link
Contributor Author

Could you please also add an integration test where a big number of persistent keys are generated with both import and generate to see that it works?

Will do 👍

@hug-dev
Copy link
Member

hug-dev commented Jun 19, 2020

Done in linked PR

@hug-dev hug-dev closed this as completed Jun 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants