Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors in validating ECC key bits in PKCS11 provider #545

Closed
ionut-arm opened this issue Oct 19, 2021 · 0 comments · Fixed by #546
Closed

Errors in validating ECC key bits in PKCS11 provider #545

ionut-arm opened this issue Oct 19, 2021 · 0 comments · Fixed by #546
Labels
bug Something isn't working small Effort label

Comments

@ionut-arm
Copy link
Member

During the development of #170 (PR: #540) a couple of tests were added to validate the parsing of inputs to public ECC key importing. Specifically, the bits field of the key attributes could be "inconsistent" in a number of ways with the size of the key actually being imported:

  • if the bits field is 0, then the length of the imported key should be used instead
  • if the bits field is a non-zero number, we should ensure that the key matches that size

While running on the CI, however, it became apparent that the PKCS11 provider does not function correctly in either of those circumstances, rejecting the import when the field is 0 and accepting it when a wrong size is provided.

@ionut-arm ionut-arm added bug Something isn't working small Effort label labels Oct 19, 2021
@ionut-arm ionut-arm added this to the Parsec Release 0.9.0 milestone Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working small Effort label
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant