Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve logging message structure #36

Closed
ionut-arm opened this issue Oct 11, 2019 · 2 comments
Closed

Improve logging message structure #36

ionut-arm opened this issue Oct 11, 2019 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@ionut-arm
Copy link
Member

Currently our log messages specify the error that occurred, however it would be useful to also include the location in code.
Example:
Currently: "Failed to read request; status: {}"
Enhanced: "FrontEndHandler handle_request: Failed to read request; status: {}"

Alternatively, when implementing actual logging, this might be sorted out for us by the logging framework (?)

@ionut-arm ionut-arm added the enhancement New feature or request label Oct 11, 2019
@hug-dev
Copy link
Member

hug-dev commented Oct 18, 2019

env_logger put in the code at #48 has the following output:

[2019-10-18T15:39:51Z INFO  parsec::providers::mbed_provider] Mbed Provider - Destroy Key

Is that what you had in mind?

@ionut-arm
Copy link
Member Author

env_logger put in the code at #48 has the following output:

[2019-10-18T15:39:51Z INFO  parsec::providers::mbed_provider] Mbed Provider - Destroy Key

Is that what you had in mind?

Yes! Though I'm not sure it'd be that helpful to admins, but better than nothing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants