-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements for tests/ci.sh #108
Comments
The points sound compelling, the reason for most of those is that the script was mainly intended to be run for CI purposes, but I think it makes sense to convert it into a "test-running script". I'm not sure if it would be worth the time investment into making it a python script instead of bash - more versatile and probably easier to work with for the future, but some cost involved in actually converting the whole thing. |
The script mostly runs commands, so I don't think it's worth converting to python |
Seems like pretty good improvements!
It would be nice indeed to find a way of checking Parsec status instead of just waiting a hard-coded timeout. That would address those two issues. |
It might be useful to use tests/ci.sh for manual testing. But, to be able to do that we can make some improvements. For example:
The text was updated successfully, but these errors were encountered: