Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make node exit future independent of error receiver #9102

Closed
mattsse opened this issue Jun 25, 2024 · 1 comment · Fixed by #9153
Closed

Make node exit future independent of error receiver #9102

mattsse opened this issue Jun 25, 2024 · 1 comment · Fixed by #9153
Assignees
Labels
C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started

Comments

@mattsse
Copy link
Collaborator

mattsse commented Jun 25, 2024

Describe the feature

/// A Future which resolves when the node exits
#[derive(Debug)]
pub struct NodeExitFuture {
/// The receiver half of the channel for the consensus engine.
/// This can be used to wait for the consensus engine to exit.
consensus_engine_rx: Option<oneshot::Receiver<Result<(), BeaconConsensusEngineError>>>,

TODO

  • replace oneshot::Receiver<Result<(), BeaconConsensusEngineError>> with a boxed future that returns eyre::Result<()> or result with boxed error

Additional context

No response

@mattsse mattsse added C-enhancement New feature or request S-needs-triage This issue needs to be labelled D-good-first-issue Nice and easy! A great choice to get started and removed S-needs-triage This issue needs to be labelled labels Jun 25, 2024
@greged93
Copy link
Contributor

Hey @mattsse can I try this one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants