Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more eth_ getraw transactions functions #6760

Closed
mattsse opened this issue Feb 23, 2024 · 3 comments · Fixed by #6827
Closed

Add more eth_ getraw transactions functions #6760

mattsse opened this issue Feb 23, 2024 · 3 comments · Fixed by #6827
Assignees
Labels
A-rpc Related to the RPC implementation C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started

Comments

@mattsse
Copy link
Collaborator

mattsse commented Feb 23, 2024

Describe the feature

TODO

Add missing eth functions:

Note for eth_getRawTransactionByHash and blob tx this needs to include the blobs:

fn get_pooled_transaction_elements(
&self,
tx_hashes: Vec<TxHash>,
limit: GetPooledTransactionLimit,
) -> Vec<PooledTransactionsElement>;

Similar to

/// Handler for `debug_getRawTransaction`
/// Returns the bytes of the transaction for the given hash.
async fn raw_transaction(&self, hash: B256) -> RpcResult<Bytes> {

but here:

/// Returns the information about a transaction requested by transaction hash.
#[method(name = "getTransactionByHash")]
async fn transaction_by_hash(&self, hash: B256) -> RpcResult<Option<Transaction>>;

fyi @loocapro

Additional context

No response

@mattsse mattsse added C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started A-rpc Related to the RPC implementation labels Feb 23, 2024
@loocapro
Copy link
Contributor

May I?

@mattsse
Copy link
Collaborator Author

mattsse commented Feb 23, 2024

assigned

@mattsse
Copy link
Collaborator Author

mattsse commented Feb 23, 2024

see also #6761

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rpc Related to the RPC implementation C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants