-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new helper trait for Network to get access to TransactionsHandle #5598
Comments
happy to take this :) ty for all this details ! |
@DoTheBestToGetTheBest I have already created a PR, so if you haven't started, let me know :) |
i still didn't started working on this but this is my issue so i will work on it, thanks |
please be excellent to each other :) @i-m-aditya I can find you something else to work on after #5604 |
@mattsse Absolutely, let's keep the good vibes going! 😄 |
I'm eager to try this challenge ! |
please choose another thing, this is my issue, i will work on it when i'am free :) i don't not abandon this :) ty for your understand |
@DoTheBestToGetTheBest are you still on this? |
i was going to work on it last week but since i can't use reth for not ( related with this #6258 ) i'm unable to work on this until fix probably someone should work on it i don't know how much time it would except for fixing CD |
@i-m-aditya @daniel-huertas hey feel free to take this if you want, i'm unable to work with reth for the moment until fix |
This issue is stale because it has been open for 21 days with no activity. |
I can try to work on this, but please don't assign me, if I can do it, there will be a PR in 24 hrs |
Describe the feature
The
TransactionsHandle
provides useful functions to interact with the network:reth/crates/net/network/src/transactions.rs
Line 72 in 503c401
It would be useful to get a
TransactionsHandle
directly from thereth/crates/net/network/src/network.rs
Line 37 in 503c401
TODO
EthNetwork
that provides a function to access theTransactionsHandle
. This should be solved by adding aMutex<Option<TransactionHandle>>
to the NetworkInnerreth/crates/net/network/src/network.rs
Line 324 in 503c401
so it can be set once the transactionmanager is installed:
reth/crates/net/network/src/manager.rs
Line 135 in 503c401
see for example:
reth/crates/net/network/src/builder.rs
Lines 59 to 62 in 503c401
then we can also move these functions to the trait:
reth/crates/net/network/src/network.rs
Lines 119 to 135 in 503c401
Additional context
No response
The text was updated successfully, but these errors were encountered: