Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manually impl Serialize for LocalizedTransactionTrace #5412

Closed
mattsse opened this issue Nov 13, 2023 · 2 comments
Closed

Manually impl Serialize for LocalizedTransactionTrace #5412

mattsse opened this issue Nov 13, 2023 · 2 comments
Assignees
Labels
A-rpc Related to the RPC implementation C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started

Comments

@mattsse
Copy link
Collaborator

mattsse commented Nov 13, 2023

Describe the feature

currently the derived Serialize order for

pub struct LocalizedTransactionTrace {

is different than what other clients emit. To make responses easier to compare we should emit the same order

TODO

Manually impl Serialize to get this order:

      {
            "action": {
                "from": "0x4f4495243837681061c4743b74b3eedf548d56a5",
                "callType": "delegatecall",
                "gas": "0x300c9b",
                "input": "0x585a9fd40000000000000000000000000000000000000000000000000000000000000040a47c5ad9a4af285720eae6cc174a9c75c5bbaf973b00f1a0c191327445b6581000000000000000000000000000000000000000000000000000000000000001e000000000000000000000000000000000000000000000000000000000000001000000000000000000000000000000000000000000000000000000000000000140000000000000000000000000ce16f69375520ab01377ce7b88f5ba8c48f8d666f61490331372e432315cd97447e3bc452d6c73a6e0536260a88ddab46f85c88d00000000000000000000000000000000000000000000000000000000000001a0000000000000000000000000000000000000000000000000000000000aab8cf0fbfb038751339cb61161fa11789b41a78f1b7b0e12cf8e467d403590b7a5f26f0000000000000000000000000000000000000000000000000000000000000008000000000000000000000000000000000000000000000000000000000000000646616e746f6d0000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000002a3078636531364636393337353532306162303133373763653742383866354241384334384638443636360000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000045553444300000000000000000000000000000000000000000000000000000000",
                "to": "0x99b5fa03a5ea4315725c43346e55a6a6fbd94098",
                "value": "0x0"
            },
            "blockHash": "0xd5ac5043011d4f16dba7841fa760c4659644b78f663b901af4673b679605ed0d",
            "blockNumber": 18557272,
            "result": {
                "gasUsed": "0x7e6c",
                "output": "0x"
            },
            "subtraces": 0,
            "traceAddress": [
                0,
                10,
                0
            ],
            "transactionHash": "0x54160ddcdbfaf98a43a43c328ebd44aa99faa765e0daa93e61145b06815a4071",
            "transactionPosition": 102,
            "type": "call"
        }

Additional context

No response

@mattsse mattsse added C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started A-rpc Related to the RPC implementation labels Nov 13, 2023
@estensen
Copy link
Contributor

I would like to work on this

@mattsse
Copy link
Collaborator Author

mattsse commented Nov 13, 2023

assigned

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rpc Related to the RPC implementation C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started
Projects
Archived in project
Development

No branches or pull requests

2 participants