Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Payloadbuilder v3 changes #4205

Closed
mattsse opened this issue Aug 15, 2023 · 1 comment
Closed

Payloadbuilder v3 changes #4205

mattsse opened this issue Aug 15, 2023 · 1 comment
Assignees
@Rjected
Labels
C-enhancement New feature or request M-changelog This change should be included in the changelog M-eip This change relates to the implementation of an EIP S-blocked This cannot more forward until something else changes

Comments

@mattsse
Copy link
Collaborator

mattsse commented Aug 15, 2023

Describe the feature

for v3 we need additional payload fields

https://github.com/ethereum/execution-apis/blob/main/src/engine/cancun.md#engine_getpayloadv3

ref

reth/crates/rpc/rpc-types/src/eth/engine/payload.rs

Lines 49 to 52 in 0840acd

//
// // TODO(mattsse): for V3
// #[serde(rename = "blobsBundle", skip_serializing_if = "Option::is_none")]
// pub blobs_bundle: Option<BlobsBundleV1>,

this must be populated by the payload builder, which needs to fetch the included blob tx data from the blobstore

blocked by #4191

ref #2894

Additional context

No response
@mattsse mattsse added C-enhancement New feature or request S-needs-triage This issue needs to be labelled S-blocked This cannot more forward until something else changes M-changelog This change should be included in the changelog M-eip This change relates to the implementation of an EIP and removed S-needs-triage This issue needs to be labelled labels Aug 15, 2023
@Rjected Rjected self-assigned this Aug 21, 2023
@Rjected Rjected mentioned this issue Aug 22, 2023
Merged
@gakonst
Copy link
Member

gakonst commented Aug 31, 2023

Can this be closed?

@mattsse mattsse closed this as completed Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Rjected Rjected

Labels
C-enhancement New feature or request M-changelog This change should be included in the changelog M-eip This change relates to the implementation of an EIP S-blocked This cannot more forward until something else changes
Projects
Reth Tracker
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Rjected @gakonst @mattsse