Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing RPC debug_ namespace function definitions #1701

Closed
mattsse opened this issue Mar 10, 2023 · 6 comments
Closed

Add missing RPC debug_ namespace function definitions #1701

mattsse opened this issue Mar 10, 2023 · 6 comments
Assignees
@supernovahs
Labels
A-rpc Related to the RPC implementation C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started

Comments

@mattsse
Copy link
Collaborator

mattsse commented Mar 10, 2023

Describe the feature

The DebugApi trait

reth/crates/rpc/rpc-api/src/debug.rs

Line 8 in ad5f9aa

pub trait DebugApi {

contains all rpc functions for the debug_ namspace:

https://geth.ethereum.org/docs/interacting-with-geth/rpc/ns-debug

TODO

  • add bindings for missing functions from the link above to DebugApi trait

Additional context

No response
@mattsse mattsse added C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started A-rpc Related to the RPC implementation labels Mar 10, 2023
@tinoh9
Copy link

tinoh9 commented Mar 11, 2023

Hi bro, can I try this one?

@mattsse
Copy link
Collaborator Author

mattsse commented Apr 4, 2023

Hey @tinoh9,

Do you still plan to work on this?

@tinoh9
Copy link

tinoh9 commented Apr 5, 2023

Sorry no bro, since currently I am busy with other stuff, so I would like to pass this to someone else who is interested.

@tinoh9 tinoh9 removed their assignment Apr 5, 2023
@mouseless0x
Copy link
Contributor

I can pick this up :)

@supernovahs
Copy link
Contributor

I can do this?

@mattsse
Copy link
Collaborator Author

mattsse commented Aug 14, 2023

sure!
even if we leave them as "unimplemented", still useful

@mattsse mattsse assigned supernovahs and unassigned mouseless0x Aug 14, 2023
@supernovahs supernovahs mentioned this issue Aug 16, 2023
Merged
@tcoratger tcoratger mentioned this issue Aug 22, 2023
Merged
@mattsse mattsse closed this as completed Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@supernovahs supernovahs

Labels
A-rpc Related to the RPC implementation C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started
Projects
Reth Tracker
Archived in project
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mattsse @supernovahs @mouseless0x @tinoh9